Fix LWFA Example: Keep Hydrogen #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
bug
Member
Author
|
\cc @n01r |
Member
|
@ax3l In the description above, did you mean Helium instead of Hydrogen? |
Member
Author
|
no the title is ok: I "change it back" to Hydrogen (a commit title should always tell what it does - the description/lines below "how" and "why"). |
Member
|
@ax3l Thx for adjusting the description - it confused me a bit. |
Member
Author
|
backported to |
PrometheusPi
added a commit
that referenced
this pull request
Feb 20, 2015
Fix LWFA Example: Keep Hydrogen
Member
|
Ah, thx @ax3l ... that was an inconsistency on my part. |
Member
Author
|
np, glad I saw it before the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #687 I did not prevent the introduction of
Hydrogen"Helium" for the LWFA example.That is actually wrong so far, since correct
hydrogenhelium would require to increase either the number of initialized electrons or their weighting. Also, the constants inphysicalConstants.paramdo not agree for that species.So far, the proton/neutron number is only an attribute - partly used for the BSI models - but it should be still consistent for each example.