Skip to content

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Feb 17, 2015

This pull request is related to #586 and reorganizes third party software (even if we are our own third party).

  • import mallocMC
    • can be overwritten with an installed mallocMC if found by CMake
  • import cuda_memtest
    • this is an independent tool, forked from sourceforge, and should be developed independently
  • import cmake-modules
    • might be used/referenced by other projects such as pngwriter or mallocMC and gets very infrequent updates
  • mpiInfo is not exported (yet) since it is too small to be relevant and might not be necessary for ever
  • src/tools as in Move Tools/CMake/ThirdParty to Own Repo #586 is not part of this pull request and will not be included via git subtree again in the future (but only removed and published in a separate repo)

The history, authorship and commits of the individual directories have been preserved in the new repositories with rewritten sha's, but for PIConGPU to keep the statistics clean we squash the thirdParty updates to a single commit per update.

The import was done, e.g., for mallocMC with

GIT_AUTHOR_NAME="Third Party" GIT_AUTHOR_EMAIL="[email protected]" \
  git subtree add --squash --prefix=thirdParty/mallocMC \
      [email protected]:ComputationalRadiationPhysics/mallocMC.git master

since git submodules which is the clean alternative is a pain for users (git clone ... && git submodule init, not included in github tar downloads, mixed commits, ...).

The teams @ComputationalRadiationPhysics/picongpu-maintainers and @ComputationalRadiationPhysics/picongpu-developers have also access to cuda_memtest and cmake-modules where the same policies as for the picongpu repositories shall apply. mallocMC is maintained by @slizzered @psychocoderHPC and @ax3l and stays like that in a separate team.

add documentation: #726

  • import / squash via fake-author (to not over-weight a maintainer)

@ax3l ax3l added refactoring code change to improve performance or to unify a concept but does not change public API component: tools scripts, python libs and CMake labels Feb 17, 2015
@ax3l ax3l mentioned this pull request Feb 17, 2015
2 tasks
@ax3l ax3l added this to the Open Beta milestone Feb 17, 2015
@ax3l
Copy link
Member Author

ax3l commented Feb 18, 2015

@psychocoderHPC you can already rebase #640 against this pull request

@ax3l ax3l mentioned this pull request Feb 20, 2015
3 tasks
@ax3l ax3l force-pushed the topic-thirdParty branch 3 times, most recently from 273cc89 to 127828a Compare February 20, 2015 10:49
ax3l and others added 8 commits February 20, 2015 11:49
- new repositories
- update contributors
in this repository, usually no commits should go to `thirdParty/`
to allow smooth upgrades via `git subtree`.
git-subtree-dir: thirdParty/cmake-modules
git-subtree-split: a47312bc6bb2eb52a1ba101d6690d3189e1aca9a
git-subtree-dir: thirdParty/cuda_memtest
git-subtree-split: f79f064
git-subtree-dir: thirdParty/mallocMC
git-subtree-split: 799d7d7
psychocoderHPC added a commit that referenced this pull request Feb 20, 2015
Restructure Third Party Software
@psychocoderHPC psychocoderHPC merged commit 5bc5e9e into ComputationalRadiationPhysics:dev Feb 20, 2015
@ax3l ax3l deleted the topic-thirdParty branch February 20, 2015 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: tools scripts, python libs and CMake refactoring code change to improve performance or to unify a concept but does not change public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants