Fix #702 Activate new plugins after restart #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrometheusPi
changed the title
PrometheusPi
added
bug
ax3l
changed the title
Member
|
huh, good catch. I missed that case while implementing it. |
Member
There was a problem hiding this comment.
That's an interesting way of checking that.
We usually use if( !boost::filesystem::exists( src ) ) for that - maybe that's more suited here, too.
also saves you the restartFile.close(); lines below.
boost:filesystem is already in the scope, so you can use a slick if( ! exists( src ) ) :)
Member
Author
There was a problem hiding this comment.
@ax3l Thanks, that's way better. I will change it to boost::filesystem::....
Member
|
great fix! 👍 |
Member
There was a problem hiding this comment.
oh, please keep it a one-liner. else it's a huge mess in parallel outputs.
ax3l
added a commit
that referenced
this pull request
Feb 17, 2015
Fix #702 Activate new plugins after restart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves issue #702:
If we add plugin calls via command line after a restart, checkpoint files for the plugin do not exists thus crashing PIConGPU during the attempt to copy checkpoint files to output files.
This pull request now checks whether a checkpoint file exists. If it does, everthing is handled as before. If the required checkpoint file does not exist, a warning is printed and we just start with data output from the restart point. PIConGPU does not crash anymore.
To Do: