Skip to content

Conversation

@PrometheusPi
Copy link
Member

With this pull request the plotNumericalHeating tool supports any number of species (#684).

It goes through the simOutput directory and looks for Energy*.dat files with first row time and second row energy.

I've tested it with some nonsense files and it worked fine.

The plotNumericalHeating tool now supports any number of species.
@PrometheusPi PrometheusPi added component: tools scripts, python libs and CMake refactoring code change to improve performance or to unify a concept but does not change public API labels Feb 11, 2015
@PrometheusPi PrometheusPi added this to the Open Beta milestone Feb 11, 2015
@ax3l ax3l changed the title Close #684 - add multispecies support Close #684 Heating Analyser for Multi Species Feb 11, 2015
@ax3l
Copy link
Member

ax3l commented Feb 11, 2015

👍
and look at the stats: +49 −65 told ya :)

@ax3l ax3l self-assigned this Feb 12, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put (yet) in brackets :) maybe it will never exist ;)
"The directory number {} does not (yet) contain {}."

@ax3l
Copy link
Member

ax3l commented Feb 12, 2015

@PrometheusPi looks ok to me, maybe a minor update in one of the error messages? :)

@PrometheusPi
Copy link
Member Author

@ax3l I will update it :)

ax3l added a commit that referenced this pull request Feb 12, 2015
@ax3l ax3l merged commit cf93d99 into ComputationalRadiationPhysics:dev Feb 12, 2015
@PrometheusPi PrometheusPi deleted the topic-multiSpeciesHeatingTool branch February 12, 2015 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: tools scripts, python libs and CMake refactoring code change to improve performance or to unify a concept but does not change public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants