openPMD-api 0.15: Use storeChunkRaw/loadChunkRaw instead of shareRaw #4578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same for loadChunkRaw
Member
|
Warning before this fix with openPMD 0.15.1 |
psychocoderHPC
approved these changes
May 26, 2023
| // getPointer() will wait for device->host transfer | ||
| ValueType* nativePtr = buffer.getHostBuffer().getPointer(); | ||
| ReinterpretedType* rawPtr = reinterpret_cast<ReinterpretedType*>(nativePtr); | ||
| #if OPENPMDAPI_VERSION_GE(0, 15, 0) |
Member
There was a problem hiding this comment.
BUG This makro was introduced with openpmd-api 0.14.5 and therefore the usage of this makro is breaking the compatibility to older version.
[update] my fold the makro is older and in 0.14.0 available too
Contributor
Author
There was a problem hiding this comment.
It's available at least an 0.13 which is the oldest supported by PIConGPU https://github.com/openPMD/openPMD-api/blob/0.13.0/include/openPMD/version.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With openPMD/openPMD-api#1229 (merged as of version 0.15), openPMD-api deprecates the use of
shareRaw(), introducing instead dedicated raw-pointer functionsstoreChunkRawandloadChunkRaw.This uses the new API if the version of openPMD-api is recent enough, mainly to avoid compilation warnings.
@psychocoderHPC