Skip to content

Backports for 0.2.5-rc2 #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
psychocoderHPC merged 4 commits into from
May 24, 2017
Merged

Backports for 0.2.5-rc2 #2068

psychocoderHPC merged 4 commits into from
May 24, 2017

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented May 24, 2017

Further backports for the 0.2.5 release (C++98):

Bug Fixes: (already in)

Misc: (added in this PR)

psychocoderHPC and others added 3 commits May 24, 2017 11:19
@psychocoderHPC @ax3l
fix shadowed member variable
33af1fa 
Remove usage of local instead of the member variable.

The result of the bug is that more buffer than needed have stored the buffer size on the device.
This results in more memory copies from/to the device.
This could be negative for the strong scaling.
@PrometheusPi @ax3l
remove extra typename in documentation of manipulators
b44c7cb
@ax3l
Warning in Socket Write
6accf16 
Handle the return code of the write to a socket.
Close ComputationalRadiationPhysics#2062
@ax3l ax3l added documentation regarding documentation or wiki discussions component: PMacc in PMacc component: user input signals changes in user API such as .param files, .cfg syntax, etc. - changelog! warning code produces/produced a warning labels May 24, 2017
@ax3l ax3l requested a review from psychocoderHPC May 24, 2017 09:27
@ax3l
Changelog Update 0.2.5
29f7d76 
Add further fixes for 0.2.5 release
@ax3l ax3l force-pushed the release-0.2.5-rc2 branch from 072425b to 29f7d76 Compare May 24, 2017 11:28
@ax3l
Copy link
Member Author

ax3l commented May 24, 2017 •
edited
Loading

the compile suite can't conver this automatically anymore since we switched the naming of our compile command to pic-compile. but I verify it manually right now

  • compile suite modules (CUDA 7.5 / C++11) - lwfa
  • hypnos CUDA 7.5 (C++11) - all examples
  • hypnos CUDA 7.0 (C++98) - all examples

@psychocoderHPC psychocoderHPC merged commit f6d58d2 into ComputationalRadiationPhysics:release-0.2.5 May 24, 2017
@ax3l ax3l mentioned this pull request May 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psychocoderHPC psychocoderHPC psychocoderHPC approved these changes

Assignees

@psychocoderHPC psychocoderHPC

Labels

component: PMacc in PMacc component: user input signals changes in user API such as .param files, .cfg syntax, etc. - changelog! documentation regarding documentation or wiki discussions warning code produces/produced a warning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ax3l @psychocoderHPC @PrometheusPi