fix #181 #182
Merged
fix #181 #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice, I will try that. |
Member
|
Works fine for me, thank you! 👍 |
ax3l
added a commit
that referenced
this pull request
Feb 6, 2014
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this pull request
Jul 30, 2020
569313f1a Merge pull request ComputationalRadiationPhysics#190 from psychocoderHPC/fix-dataRaces c2505573d Merge pull request ComputationalRadiationPhysics#189 from psychocoderHPC/fix-mallocMCExample03 cbfa6a2bc fix data races in `Scatter.hpp` b744e97aa fix data race and printf issue 520441e5b Merge pull request ComputationalRadiationPhysics#188 from psychocoderHPC/topic-updateAlpaka 136f73013 Merge commit '01e9abcfa60f1a5c9a1373321e9286374c57027c' into topic-updateAlpaka 01e9abcfa Squashed 'alpaka/' changes from 3e8567126..34870a73e 47b3e4c9b Refactoring (ComputationalRadiationPhysics#181) 25076a35d Merge pull request ComputationalRadiationPhysics#185 from psychocoderHPC/topic-updateAlpakaSubtree c1e596b3f Merge pull request ComputationalRadiationPhysics#187 from psychocoderHPC/topic-gitIgnoreUpdate b7aac310d Merge pull request ComputationalRadiationPhysics#186 from psychocoderHPC/topic-updateDevVersion 97c420697 update gitignore f658ad286 update evrsion to 2.5.0-crp-dev 9d6e21640 Squashed 'alpaka/' changes from b2a80b16..3e856712 63e5a3762 Merge commit '9d6e216402149143b07efe610265a171fe7ed062' into topic-updateAlpakaSubtree 2dc0bef38 Merge commit 'f2a664bcc2f3a201a309e48f3e0ced11e1a0667e' into topic-updateAlpakaSubtree f2a664bcc Squashed 'alpaka/' changes from a5a8277c..b2a80b16 5bced863b Merge pull request ComputationalRadiationPhysics#182 from psychocoderHPC/fix-HIPSupport c3605a691 fix HIP support 31f9b3c3f version update 2.4.0crp and changelog (ComputationalRadiationPhysics#157) cc54375b1 Port to alpaka (ComputationalRadiationPhysics#173) a2ed3ae92 Merge pull request ComputationalRadiationPhysics#179 from bernhardmgruber/catch 8dd82718e added 3rd party catch.hpp and made CMake find it 67bdc1b59 Merge pull request ComputationalRadiationPhysics#176 from bernhardmgruber/addAlpaka 5dd1d036c switching to C++14 2bb2f3e6d * using alpaka from added git subtree 90bb1ebc6 Squashed 'alpaka/' content from commit a5a8277cd ea7317878 Merge commit '90bb1ebc63d8281718381494e1d91733ac79c405' as 'alpaka' e0be7743e Merge pull request ComputationalRadiationPhysics#178 from psychocoderHPC/fix-travisCmakeUsage2 28b81447f fix used cmake version be77c4c60 Merge pull request ComputationalRadiationPhysics#174 from psychocoderHPC/topic-updateCmakeTo3.15.0 90d284197 update cmake to 3.15.0 7a3d1cebd Merge pull request ComputationalRadiationPhysics#172 from bernhardmgruber/format 018543832 added CONTRIBUTING.md with instructions how to use clang-format 4a416a2ec formatting (after clang-tidy) 8aec2cbf3 using trailing return types 5661a80fc formatting 669443d55 * setting column limit and allowing short loops * regrouping includes edc10db7c added .clang-format file 8c5a8617d Merge pull request ComputationalRadiationPhysics#171 from bernhardmgruber/cleaning 95c3223f2 replaced remaining typedefs by using directives d008ddba6 added .vs and build folders to ignores 5c16da78a applied clang-tidy 6404efdf6 * added a custom target for mallocMC headers * added header files to projects 43754615d Merge pull request ComputationalRadiationPhysics#169 from bernhardmgruber/cleaning 28561514d * requiring only C++11 * removed a TODO 507111408 a little modernization of the CMakeLists * using CUDA via project language instead of deprecated find_package * setting CUDA standard to have C++14 inside CUDA as well 73e21de40 * removed check that pagesize is unsigned * made pagesizes signed literals again 25e0de345 renamed variables with 2 leading underscores 240d4ea63 Suggested during review d37e9ed21 addressed review comments dafc9b794 * replaced usage of boost::mpl by static constexpr members * dropped dependency on boost 4962156bf some cleanup * requiring C++14 * using cstdint instead of boost/cstdint.hpp * using std::tuple instead of boost::tuple * using nullptr * using static_assert * using constexpr * adding const and static where appropriate * removed a few empty lines * replaced std::endl by \n where flush was probably not intended e383f3cd8 Merge pull request ComputationalRadiationPhysics#170 from ax3l/topic-ciBionic 42aed7eaf Travis CI: GCC 5.5.0 + CUDA 9.1.85 36cb7f9f0 Merge pull request ComputationalRadiationPhysics#165 from sbastrakov/topic-nvccComputeCapabilityGuard d911d0cbb Add a guard around COMPUTE_CAPABILITY cmake variable eff012d66 Merge pull request ComputationalRadiationPhysics#161 from sbastrakov/topic-cudaDeviceGetArrribute efd20bce5 Merge pull request ComputationalRadiationPhysics#164 from sbastrakov/fix-nvccComputeCapability 450c73d3a Choose the value for the -arch nvcc flag depending on CUDA version ce377f18e Use cudaDeviceGetAttribute() for querying the compute capability git-subtree-dir: thirdParty/mallocMC git-subtree-split: 569313f1adb06ed2a221a975e7d909e4bcef6339
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this pull request
Jul 30, 2020
569313f1a Merge pull request ComputationalRadiationPhysics#190 from psychocoderHPC/fix-dataRaces c2505573d Merge pull request ComputationalRadiationPhysics#189 from psychocoderHPC/fix-mallocMCExample03 cbfa6a2bc fix data races in `Scatter.hpp` b744e97aa fix data race and printf issue 520441e5b Merge pull request ComputationalRadiationPhysics#188 from psychocoderHPC/topic-updateAlpaka 136f73013 Merge commit '01e9abcfa60f1a5c9a1373321e9286374c57027c' into topic-updateAlpaka 01e9abcfa Squashed 'alpaka/' changes from 3e8567126..34870a73e 47b3e4c9b Refactoring (ComputationalRadiationPhysics#181) 25076a35d Merge pull request ComputationalRadiationPhysics#185 from psychocoderHPC/topic-updateAlpakaSubtree c1e596b3f Merge pull request ComputationalRadiationPhysics#187 from psychocoderHPC/topic-gitIgnoreUpdate b7aac310d Merge pull request ComputationalRadiationPhysics#186 from psychocoderHPC/topic-updateDevVersion 97c420697 update gitignore f658ad286 update evrsion to 2.5.0-crp-dev 9d6e21640 Squashed 'alpaka/' changes from b2a80b16..3e856712 63e5a3762 Merge commit '9d6e216402149143b07efe610265a171fe7ed062' into topic-updateAlpakaSubtree 2dc0bef38 Merge commit 'f2a664bcc2f3a201a309e48f3e0ced11e1a0667e' into topic-updateAlpakaSubtree f2a664bcc Squashed 'alpaka/' changes from a5a8277c..b2a80b16 5bced863b Merge pull request ComputationalRadiationPhysics#182 from psychocoderHPC/fix-HIPSupport c3605a691 fix HIP support 31f9b3c3f version update 2.4.0crp and changelog (ComputationalRadiationPhysics#157) cc54375b1 Port to alpaka (ComputationalRadiationPhysics#173) a2ed3ae92 Merge pull request ComputationalRadiationPhysics#179 from bernhardmgruber/catch 8dd82718e added 3rd party catch.hpp and made CMake find it 67bdc1b59 Merge pull request ComputationalRadiationPhysics#176 from bernhardmgruber/addAlpaka 5dd1d036c switching to C++14 2bb2f3e6d * using alpaka from added git subtree 90bb1ebc6 Squashed 'alpaka/' content from commit a5a8277cd ea7317878 Merge commit '90bb1ebc63d8281718381494e1d91733ac79c405' as 'alpaka' e0be7743e Merge pull request ComputationalRadiationPhysics#178 from psychocoderHPC/fix-travisCmakeUsage2 28b81447f fix used cmake version be77c4c60 Merge pull request ComputationalRadiationPhysics#174 from psychocoderHPC/topic-updateCmakeTo3.15.0 90d284197 update cmake to 3.15.0 7a3d1cebd Merge pull request ComputationalRadiationPhysics#172 from bernhardmgruber/format 018543832 added CONTRIBUTING.md with instructions how to use clang-format 4a416a2ec formatting (after clang-tidy) 8aec2cbf3 using trailing return types 5661a80fc formatting 669443d55 * setting column limit and allowing short loops * regrouping includes edc10db7c added .clang-format file 8c5a8617d Merge pull request ComputationalRadiationPhysics#171 from bernhardmgruber/cleaning 95c3223f2 replaced remaining typedefs by using directives d008ddba6 added .vs and build folders to ignores 5c16da78a applied clang-tidy 6404efdf6 * added a custom target for mallocMC headers * added header files to projects 43754615d Merge pull request ComputationalRadiationPhysics#169 from bernhardmgruber/cleaning 28561514d * requiring only C++11 * removed a TODO 507111408 a little modernization of the CMakeLists * using CUDA via project language instead of deprecated find_package * setting CUDA standard to have C++14 inside CUDA as well 73e21de40 * removed check that pagesize is unsigned * made pagesizes signed literals again 25e0de345 renamed variables with 2 leading underscores 240d4ea63 Suggested during review d37e9ed21 addressed review comments dafc9b794 * replaced usage of boost::mpl by static constexpr members * dropped dependency on boost 4962156bf some cleanup * requiring C++14 * using cstdint instead of boost/cstdint.hpp * using std::tuple instead of boost::tuple * using nullptr * using static_assert * using constexpr * adding const and static where appropriate * removed a few empty lines * replaced std::endl by \n where flush was probably not intended e383f3cd8 Merge pull request ComputationalRadiationPhysics#170 from ax3l/topic-ciBionic 42aed7eaf Travis CI: GCC 5.5.0 + CUDA 9.1.85 36cb7f9f0 Merge pull request ComputationalRadiationPhysics#165 from sbastrakov/topic-nvccComputeCapabilityGuard d911d0cbb Add a guard around COMPUTE_CAPABILITY cmake variable eff012d66 Merge pull request ComputationalRadiationPhysics#161 from sbastrakov/topic-cudaDeviceGetArrribute efd20bce5 Merge pull request ComputationalRadiationPhysics#164 from sbastrakov/fix-nvccComputeCapability 450c73d3a Choose the value for the -arch nvcc flag depending on CUDA version ce377f18e Use cudaDeviceGetAttribute() for querying the compute capability git-subtree-dir: thirdParty/mallocMC git-subtree-split: 569313f1adb06ed2a221a975e7d909e4bcef6339
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this pull request
Aug 6, 2020
e444645d0 Merge pull request ComputationalRadiationPhysics#193 from psychocoderHPC/fix-hipclangRuntimeIssue 4875be15d Merge pull request ComputationalRadiationPhysics#192 from psychocoderHPC/fix-threadFence fdb48b705 fix clang cuda compile e99d634c8 fix HIP-clang runtime issues cb218948b update CONTRIBUTING.md (ComputationalRadiationPhysics#191) 569313f1a Merge pull request ComputationalRadiationPhysics#190 from psychocoderHPC/fix-dataRaces c2505573d Merge pull request ComputationalRadiationPhysics#189 from psychocoderHPC/fix-mallocMCExample03 cbfa6a2bc fix data races in `Scatter.hpp` b744e97aa fix data race and printf issue 520441e5b Merge pull request ComputationalRadiationPhysics#188 from psychocoderHPC/topic-updateAlpaka 136f73013 Merge commit '01e9abcfa60f1a5c9a1373321e9286374c57027c' into topic-updateAlpaka 01e9abcfa Squashed 'alpaka/' changes from 3e8567126..34870a73e 47b3e4c9b Refactoring (ComputationalRadiationPhysics#181) 25076a35d Merge pull request ComputationalRadiationPhysics#185 from psychocoderHPC/topic-updateAlpakaSubtree c1e596b3f Merge pull request ComputationalRadiationPhysics#187 from psychocoderHPC/topic-gitIgnoreUpdate b7aac310d Merge pull request ComputationalRadiationPhysics#186 from psychocoderHPC/topic-updateDevVersion 97c420697 update gitignore f658ad286 update evrsion to 2.5.0-crp-dev 9d6e21640 Squashed 'alpaka/' changes from b2a80b16..3e856712 63e5a3762 Merge commit '9d6e216402149143b07efe610265a171fe7ed062' into topic-updateAlpakaSubtree 2dc0bef38 Merge commit 'f2a664bcc2f3a201a309e48f3e0ced11e1a0667e' into topic-updateAlpakaSubtree f2a664bcc Squashed 'alpaka/' changes from a5a8277c..b2a80b16 5bced863b Merge pull request ComputationalRadiationPhysics#182 from psychocoderHPC/fix-HIPSupport c3605a691 fix HIP support 31f9b3c3f version update 2.4.0crp and changelog (ComputationalRadiationPhysics#157) cc54375b1 Port to alpaka (ComputationalRadiationPhysics#173) a2ed3ae92 Merge pull request ComputationalRadiationPhysics#179 from bernhardmgruber/catch 8dd82718e added 3rd party catch.hpp and made CMake find it 67bdc1b59 Merge pull request ComputationalRadiationPhysics#176 from bernhardmgruber/addAlpaka 5dd1d036c switching to C++14 2bb2f3e6d * using alpaka from added git subtree 90bb1ebc6 Squashed 'alpaka/' content from commit a5a8277cd ea7317878 Merge commit '90bb1ebc63d8281718381494e1d91733ac79c405' as 'alpaka' e0be7743e Merge pull request ComputationalRadiationPhysics#178 from psychocoderHPC/fix-travisCmakeUsage2 28b81447f fix used cmake version be77c4c60 Merge pull request ComputationalRadiationPhysics#174 from psychocoderHPC/topic-updateCmakeTo3.15.0 90d284197 update cmake to 3.15.0 7a3d1cebd Merge pull request ComputationalRadiationPhysics#172 from bernhardmgruber/format 018543832 added CONTRIBUTING.md with instructions how to use clang-format 4a416a2ec formatting (after clang-tidy) 8aec2cbf3 using trailing return types 5661a80fc formatting 669443d55 * setting column limit and allowing short loops * regrouping includes edc10db7c added .clang-format file 8c5a8617d Merge pull request ComputationalRadiationPhysics#171 from bernhardmgruber/cleaning 95c3223f2 replaced remaining typedefs by using directives d008ddba6 added .vs and build folders to ignores 5c16da78a applied clang-tidy 6404efdf6 * added a custom target for mallocMC headers * added header files to projects 43754615d Merge pull request ComputationalRadiationPhysics#169 from bernhardmgruber/cleaning 28561514d * requiring only C++11 * removed a TODO 507111408 a little modernization of the CMakeLists * using CUDA via project language instead of deprecated find_package * setting CUDA standard to have C++14 inside CUDA as well 73e21de40 * removed check that pagesize is unsigned * made pagesizes signed literals again 25e0de345 renamed variables with 2 leading underscores 240d4ea63 Suggested during review d37e9ed21 addressed review comments dafc9b794 * replaced usage of boost::mpl by static constexpr members * dropped dependency on boost 4962156bf some cleanup * requiring C++14 * using cstdint instead of boost/cstdint.hpp * using std::tuple instead of boost::tuple * using nullptr * using static_assert * using constexpr * adding const and static where appropriate * removed a few empty lines * replaced std::endl by \n where flush was probably not intended e383f3cd8 Merge pull request ComputationalRadiationPhysics#170 from ax3l/topic-ciBionic 42aed7eaf Travis CI: GCC 5.5.0 + CUDA 9.1.85 36cb7f9f0 Merge pull request ComputationalRadiationPhysics#165 from sbastrakov/topic-nvccComputeCapabilityGuard d911d0cbb Add a guard around COMPUTE_CAPABILITY cmake variable eff012d66 Merge pull request ComputationalRadiationPhysics#161 from sbastrakov/topic-cudaDeviceGetArrribute efd20bce5 Merge pull request ComputationalRadiationPhysics#164 from sbastrakov/fix-nvccComputeCapability 450c73d3a Choose the value for the -arch nvcc flag depending on CUDA version ce377f18e Use cudaDeviceGetAttribute() for querying the compute capability git-subtree-dir: thirdParty/mallocMC git-subtree-split: e444645d0e97a5821dcd22a0d3bf3af53e6a0fd9
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this pull request
Aug 11, 2020
e444645d0 Merge pull request ComputationalRadiationPhysics#193 from psychocoderHPC/fix-hipclangRuntimeIssue 4875be15d Merge pull request ComputationalRadiationPhysics#192 from psychocoderHPC/fix-threadFence fdb48b705 fix clang cuda compile e99d634c8 fix HIP-clang runtime issues cb218948b update CONTRIBUTING.md (ComputationalRadiationPhysics#191) 569313f1a Merge pull request ComputationalRadiationPhysics#190 from psychocoderHPC/fix-dataRaces c2505573d Merge pull request ComputationalRadiationPhysics#189 from psychocoderHPC/fix-mallocMCExample03 cbfa6a2bc fix data races in `Scatter.hpp` b744e97aa fix data race and printf issue 520441e5b Merge pull request ComputationalRadiationPhysics#188 from psychocoderHPC/topic-updateAlpaka 136f73013 Merge commit '01e9abcfa60f1a5c9a1373321e9286374c57027c' into topic-updateAlpaka 01e9abcfa Squashed 'alpaka/' changes from 3e8567126..34870a73e 47b3e4c9b Refactoring (ComputationalRadiationPhysics#181) 25076a35d Merge pull request ComputationalRadiationPhysics#185 from psychocoderHPC/topic-updateAlpakaSubtree c1e596b3f Merge pull request ComputationalRadiationPhysics#187 from psychocoderHPC/topic-gitIgnoreUpdate b7aac310d Merge pull request ComputationalRadiationPhysics#186 from psychocoderHPC/topic-updateDevVersion 97c420697 update gitignore f658ad286 update evrsion to 2.5.0-crp-dev 9d6e21640 Squashed 'alpaka/' changes from b2a80b16..3e856712 63e5a3762 Merge commit '9d6e216402149143b07efe610265a171fe7ed062' into topic-updateAlpakaSubtree 2dc0bef38 Merge commit 'f2a664bcc2f3a201a309e48f3e0ced11e1a0667e' into topic-updateAlpakaSubtree f2a664bcc Squashed 'alpaka/' changes from a5a8277c..b2a80b16 5bced863b Merge pull request ComputationalRadiationPhysics#182 from psychocoderHPC/fix-HIPSupport c3605a691 fix HIP support 31f9b3c3f version update 2.4.0crp and changelog (ComputationalRadiationPhysics#157) cc54375b1 Port to alpaka (ComputationalRadiationPhysics#173) a2ed3ae92 Merge pull request ComputationalRadiationPhysics#179 from bernhardmgruber/catch 8dd82718e added 3rd party catch.hpp and made CMake find it 67bdc1b59 Merge pull request ComputationalRadiationPhysics#176 from bernhardmgruber/addAlpaka 5dd1d036c switching to C++14 2bb2f3e6d * using alpaka from added git subtree 90bb1ebc6 Squashed 'alpaka/' content from commit a5a8277cd ea7317878 Merge commit '90bb1ebc63d8281718381494e1d91733ac79c405' as 'alpaka' e0be7743e Merge pull request ComputationalRadiationPhysics#178 from psychocoderHPC/fix-travisCmakeUsage2 28b81447f fix used cmake version be77c4c60 Merge pull request ComputationalRadiationPhysics#174 from psychocoderHPC/topic-updateCmakeTo3.15.0 90d284197 update cmake to 3.15.0 7a3d1cebd Merge pull request ComputationalRadiationPhysics#172 from bernhardmgruber/format 018543832 added CONTRIBUTING.md with instructions how to use clang-format 4a416a2ec formatting (after clang-tidy) 8aec2cbf3 using trailing return types 5661a80fc formatting 669443d55 * setting column limit and allowing short loops * regrouping includes edc10db7c added .clang-format file 8c5a8617d Merge pull request ComputationalRadiationPhysics#171 from bernhardmgruber/cleaning 95c3223f2 replaced remaining typedefs by using directives d008ddba6 added .vs and build folders to ignores 5c16da78a applied clang-tidy 6404efdf6 * added a custom target for mallocMC headers * added header files to projects 43754615d Merge pull request ComputationalRadiationPhysics#169 from bernhardmgruber/cleaning 28561514d * requiring only C++11 * removed a TODO 507111408 a little modernization of the CMakeLists * using CUDA via project language instead of deprecated find_package * setting CUDA standard to have C++14 inside CUDA as well 73e21de40 * removed check that pagesize is unsigned * made pagesizes signed literals again 25e0de345 renamed variables with 2 leading underscores 240d4ea63 Suggested during review d37e9ed21 addressed review comments dafc9b794 * replaced usage of boost::mpl by static constexpr members * dropped dependency on boost 4962156bf some cleanup * requiring C++14 * using cstdint instead of boost/cstdint.hpp * using std::tuple instead of boost::tuple * using nullptr * using static_assert * using constexpr * adding const and static where appropriate * removed a few empty lines * replaced std::endl by \n where flush was probably not intended e383f3cd8 Merge pull request ComputationalRadiationPhysics#170 from ax3l/topic-ciBionic 42aed7eaf Travis CI: GCC 5.5.0 + CUDA 9.1.85 36cb7f9f0 Merge pull request ComputationalRadiationPhysics#165 from sbastrakov/topic-nvccComputeCapabilityGuard d911d0cbb Add a guard around COMPUTE_CAPABILITY cmake variable eff012d66 Merge pull request ComputationalRadiationPhysics#161 from sbastrakov/topic-cudaDeviceGetArrribute efd20bce5 Merge pull request ComputationalRadiationPhysics#164 from sbastrakov/fix-nvccComputeCapability 450c73d3a Choose the value for the -arch nvcc flag depending on CUDA version ce377f18e Use cudaDeviceGetAttribute() for querying the compute capability git-subtree-dir: thirdParty/mallocMC git-subtree-split: e444645d0e97a5821dcd22a0d3bf3af53e6a0fd9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.