Skip to content

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Feb 8, 2017

Adds NIST tables for commonly used elements in our experiments, so users can use them directly. Covers: Dopants (He, N, also Ar could be relevant), Plastics & Surface Dirt (C, O, N), and commonly used benchmark materials (Al, Cu).

@ax3l ax3l added documentation regarding documentation or wiki discussions component: examples PIConGPU or PMacc examples labels Feb 8, 2017
@ax3l ax3l added this to the Next Stable: 0.3.0 / 1.0.0 milestone Feb 8, 2017
@ax3l ax3l requested a review from n01r February 8, 2017 10:22
Copy link
Member

@n01r n01r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for the detailed handywork!

);

/* Example: helium */
PMACC_CONST_VECTOR(float_X, 6, Z_EFFECTIVE_HELIUM,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PMACC_CONST_VECTOR(float_X, 2, Z_EFFECTIVE_HELIUM,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh oh!

/* ionization energy for ground state hydrogen in atomic units */
PMACC_CONST_VECTOR(float_X,1,IONIZATION_ENERGY_HYDROGEN,
PMACC_CONST_VECTOR(float_X, 1, IONIZATION_ENERGY_HYDROGEN,
13.60569 * UNITCONV_eV_to_AU
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm ... so do we change this to 13.598434005136 now as found here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D who's closer to you? Schrödinger or an experimental measurement that says to a high precision that 13.6 is slightly slightly overestimated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like a cat in a box

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh wait, the red brackets mean it is a theoretical value

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so NIST it is, for consistency

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyone who differs can very well use their own value ... like 3 ... or 15 ... the options are limitless

@ax3l ax3l force-pushed the topic-moreIonizationTables branch from 8554656 to 13e11b2 Compare February 8, 2017 10:47
Adds NIST tables for commonly used elements in our experiments,
so users can use them directly. Covers: Dopants (He, N, also
Ar could be relevant), Plastics & Surface Dirt (C, O, N),
and commonly used benchmark materials (Al, Cu).
@ax3l ax3l force-pushed the topic-moreIonizationTables branch from 13e11b2 to 272707b Compare February 8, 2017 10:51
@ax3l ax3l requested a review from psychocoderHPC February 8, 2017 16:21
@psychocoderHPC psychocoderHPC merged commit 2603b97 into ComputationalRadiationPhysics:dev Feb 8, 2017
@ax3l ax3l deleted the topic-moreIonizationTables branch February 8, 2017 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: examples PIConGPU or PMacc examples documentation regarding documentation or wiki discussions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants