-
Notifications
You must be signed in to change notification settings - Fork 225
Ionization Configs: Add He, C, O, Al, Cu #1804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ionization Configs: Add He, C, O, Al, Cu #1804
Conversation
n01r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch for the detailed handywork!
| ); | ||
|
|
||
| /* Example: helium */ | ||
| PMACC_CONST_VECTOR(float_X, 6, Z_EFFECTIVE_HELIUM, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PMACC_CONST_VECTOR(float_X, 2, Z_EFFECTIVE_HELIUM,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh oh!
| /* ionization energy for ground state hydrogen in atomic units */ | ||
| PMACC_CONST_VECTOR(float_X,1,IONIZATION_ENERGY_HYDROGEN, | ||
| PMACC_CONST_VECTOR(float_X, 1, IONIZATION_ENERGY_HYDROGEN, | ||
| 13.60569 * UNITCONV_eV_to_AU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ... so do we change this to 13.598434005136 now as found here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D who's closer to you? Schrödinger or an experimental measurement that says to a high precision that 13.6 is slightly slightly overestimated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like a cat in a box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh wait, the red brackets mean it is a theoretical value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so NIST it is, for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyone who differs can very well use their own value ... like 3 ... or 15 ... the options are limitless
8554656 to
13e11b2
Compare
Adds NIST tables for commonly used elements in our experiments, so users can use them directly. Covers: Dopants (He, N, also Ar could be relevant), Plastics & Surface Dirt (C, O, N), and commonly used benchmark materials (Al, Cu).
13e11b2 to
272707b
Compare
Adds NIST tables for commonly used elements in our experiments, so users can use them directly. Covers: Dopants (He, N, also Ar could be relevant), Plastics & Surface Dirt (C, O, N), and commonly used benchmark materials (Al, Cu).