fix tbg variable substitution#1609
Merged
ax3l merged 2 commits intoOct 27, 2016
Merged
Conversation
delete command to remove variable definitions from the template file
Member
Author
|
This bug fix need that we change all |
Batch system commands must defined before any bash command. Move batch system commands before bash commands.
Member
Author
|
updated this pull request |
Member
Author
|
UPDATE: I have not seen in my tests that this pull request now creates error's during the job start. This is not critical but should be solved. |
Member
Author
|
@ComputationalRadiationPhysics/picongpu-developers This pull request breaks the old template files. Please use the new |
psychocoderHPC
added a commit
to psychocoderHPC/picongpu
that referenced
this pull request
Nov 1, 2016
- fix runtime errors which comming in with ComputationalRadiationPhysics#1609 - revert dirty evaluation from ComputationalRadiationPhysics#1611 - fix tbg `-o` parameter - add new syntax to define variables in the tpl file `.varname=value`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #695
someThing=...from the template file*.tplfiles: move batch system commands above (the now still existing) bash commandsReason for
*.tplchange:Batch system commands must be defined before any bash command. Before this pull request
tbgdeleted all variable definitions in the template file and therefore fulfilled the batch system restriction.Removing variable assignments (and due to that defined variables in
.start) withtbgresults in side effects and limited functionality for the template file (since those runtime variables will be missing in the.startscript).Old
*.tplfiles are not compatible to this pull request