Skip to content

fix tbg variable substitution#1609

Merged
ax3l merged 2 commits into
ComputationalRadiationPhysics:devfrom
psychocoderHPC:fix-tbgSubstitution
Oct 27, 2016
Merged

fix tbg variable substitution#1609
ax3l merged 2 commits into
ComputationalRadiationPhysics:devfrom
psychocoderHPC:fix-tbgSubstitution

Conversation

@psychocoderHPC
Copy link
Copy Markdown
Member

@psychocoderHPC psychocoderHPC commented Oct 26, 2016

close #695

  • delete command that removed variable definitions someThing=... from the template file
  • *.tpl files: move batch system commands above (the now still existing) bash commands

Reason for *.tpl change:
Batch system commands must be defined before any bash command. Before this pull request tbg deleted all variable definitions in the template file and therefore fulfilled the batch system restriction.

Removing variable assignments (and due to that defined variables in .start) with tbg results in side effects and limited functionality for the template file (since those runtime variables will be missing in the .start script).

Old *.tpl files are not compatible to this pull request

delete command to remove variable definitions from the template file
@psychocoderHPC psychocoderHPC added affects latest release a bug that affects the latest stable release bug a bug in the project's code component: tools scripts, python libs and CMake labels Oct 26, 2016
@psychocoderHPC psychocoderHPC added this to the 0.2.0: Open Beta milestone Oct 26, 2016
@psychocoderHPC
Copy link
Copy Markdown
Member Author

This bug fix need that we change all *.tpl files before the first batch system command e.g. #PBS -q queueName it is not allowed to place any bash commands.

@psychocoderHPC psychocoderHPC modified the milestones: Next Stable: 0.3.0 / 1.0.0, 0.2.0: Open Beta Oct 26, 2016
Batch system commands must defined before any bash command.
Move batch system commands before bash commands.
@psychocoderHPC
Copy link
Copy Markdown
Member Author

updated this pull request

@ax3l ax3l modified the milestones: 0.2.0: Open Beta, Next Stable: 0.3.0 / 1.0.0 Oct 27, 2016
@ax3l ax3l merged commit b698543 into ComputationalRadiationPhysics:dev Oct 27, 2016
@psychocoderHPC psychocoderHPC deleted the fix-tbgSubstitution branch October 27, 2016 12:48
@psychocoderHPC
Copy link
Copy Markdown
Member Author

psychocoderHPC commented Oct 27, 2016

UPDATE: I have not seen in my tests that this pull request now creates error's during the job start. This is not critical but should be solved.

/var/spool/torque/mom_priv/jobs/976719.hypnos3.SC: line 47: [: -gt: unary operator expected
/var/spool/torque/mom_priv/jobs/976719.hypnos3.SC: line 53: ( TBG_tasks + TBG_gpusPerNode -1 ) / TBG_gpusPerNode: division by 0 (error token is "TBG_gpusPerNode")

@psychocoderHPC
Copy link
Copy Markdown
Member Author

@ComputationalRadiationPhysics/picongpu-developers This pull request breaks the old template files. Please use the new *.tpl files!

psychocoderHPC added a commit to psychocoderHPC/picongpu that referenced this pull request Nov 1, 2016
- fix runtime errors which comming in with ComputationalRadiationPhysics#1609
- revert dirty evaluation from ComputationalRadiationPhysics#1611
- fix tbg `-o` parameter
- add new syntax to define variables in the tpl file `.varname=value`
ax3l pushed a commit that referenced this pull request Nov 2, 2016
- fix runtime errors which comming in with #1609
- revert dirty evaluation from #1611
- fix tbg `-o` parameter
- add new syntax to define variables in the tpl file `.varname=value`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affects latest release a bug that affects the latest stable release bug a bug in the project's code component: tools scripts, python libs and CMake

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants