Actually set the total GPU offset #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychocoderHPC
added
bug
Member
|
oh my, well spotted. only affects |
Member
|
@n01r can you pls cross-check if the same affects you for the ionization seeds? probably cloned from this position in the code. |
ax3l
added a commit
that referenced
this pull request
Aug 13, 2015
Actually set the total GPU offset
Member
|
this should have caused an "unused variable" warning... weird. @Flamefire if you are interested, can you pls compile PIConGPU once with |
Member
|
@ax3l This is actually how @Flamefire spotted the bug, when we were discussing the ionization seed. |
Member
|
sweet. did you fix the same seeding in ionization? |
ax3l
referenced
this pull request
in n01r/picongpu
Aug 13, 2015
- `ionization.hpp`: Add documentation to clarify the domain coordinates
- `ionizationMehtods.hpp`: Use the correct cell index inside the local domain
to improve seeding.
Also added documentation.
Member
|
jup ... workaround-ish for now and when the PRs are merged it can be done properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting the instance variable a local variable was created and ignored. This results in different local indices instead of same ones which may cause collisions when xoring with already local seeds.
only affects
dev.