Skip to content

Renaming Ionization Framework #963

@n01r

Description

@n01r

I would like to rename all parts in the ionization framework to enhance transparency and to avoid misunderstandings.
Therefore I would propose the following changes:

ionization.hpp --> ionization.kernel
After all the refactoring all that is left of the contents is the kernel.
ionization/byField/ionizers.[def|hpp] --> ionization/byField/fieldIonizationModels.[def|hpp]
because these files just collect the .def and .hpp files of the models and thus are a list of the models
AlgorithmADK[None/BSI/...].hpp --> ADK[BSI/none/...]Calc.hpp
All files belonging to a certain model should have names starting with the model name, right?
otherwise: CalcADK? CompADK? ADKComp[utation]?
Introduce a new file fieldIonizationCalc.hpp
containing all the includes for the calculation of the models, like e.g. ADKCalc.hpp

Do you think ionizerConfig.[param|unitless] can keep its name? Right now it just does forward declaration / collects includes but I am positive that we might soon get model-specific quantities that we will have to make unitless. (e.g. Keldysh parameter)

  • To do after changes: update the Wiki

Please feel free to suggest more suitable names if you can think of any.

Metadata

Metadata

Assignees

Labels

refactoringcode change to improve performance or to unify a concept but does not change public API

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions