Lase Polynom: Precision

[ax3l]

In the laserPolynom implementation, the use of doubles and floats can be stated a bit more precisely.

Probably the authors aimed to calculate the sine in double precision, but the style of casts is a bit wild. 🐱

[PrometheusPi]

@psychocoderHPC and/or @Heikman what was the reason you used double in this case?

[PrometheusPi]

@ax3l Waiting for #708 to be merged to dev.

[psychocoderHPC]

@PrometheusPi pleasse ask @PrometheusPi he was the original author of this file ^^

[PrometheusPi]

Ohhh! This is the [insert_proprietary_PIC_code_name]TestLaser 😕
How could I forget this?

[PrometheusPi]

@ComputationalRadiationPhysics/picongpu-maintainers What do you think of another renaming of the laser to shortSteplessLaser?

[ax3l]

I think the polynom describes the longitudinal envelope, right? So I think the current name is fine.

[PrometheusPi]

I think, polynom is to general since it is a specific polynom with root and extrema at start and end point.

[ax3l]

ah good to know.
in that case you could also name it by the order of the polynomial.

[PrometheusPi]

Yes, which is however still too general (except if you state the boundary conditions as well). Even with a given order, an infinit number of polynoms are possible.

[ax3l]

ah ok, sounded to me like this specific implementation is fixed to one order.