This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Merged
Conversation
…ng to ItemsSource Avoids bug CommunityToolkit#4248
|
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
XAML-Knight
approved these changes
Sep 15, 2021
Rosuavio
approved these changes
Sep 16, 2021
|
Hello @RosarioPulella! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4210 and Fixes #4158
Cleans up sample for #4248 (though underlying issue remains to be figured out later).
Fixes a sample and cleans-up a few items we missed in our nuget packages. Just need to validate output from CI, but should be fairly straight-forward.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
TTB Sample was binding to the internal collection instead of showing binding to a developer provided collection.
Some new features were missing from the NuGet package info.
What is the new behavior?
Fixed! 🎉
PR Checklist
Please check if your PR fulfills the following requirements:
Other information