This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Add Value Coercion to ConstrainedBox#4169
Merged
michael-hawker merged 7 commits intoCommunityToolkit:mainfrom Aug 16, 2021
Merged
Add Value Coercion to ConstrainedBox#4169michael-hawker merged 7 commits intoCommunityToolkit:mainfrom
michael-hawker merged 7 commits intoCommunityToolkit:mainfrom
Conversation
|
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
…thin a parent for completeness.
Member
Author
|
Alright added all the tests, should be descent coverage for now until we get real-world scenarios of usage. This PR ready to review. |
XAML-Knight
suggested changes
Aug 11, 2021
michael-hawker
commented
Aug 12, 2021
…ConstrainedBox.Alignment.cs
|
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
XAML-Knight
approved these changes
Aug 12, 2021
Member
Author
|
@chingucoding know you had called out the Value Coercion initially, so let me know if you want to review or not? |
Contributor
|
Sure @michael-hawker , I would love to review this in the next few days! |
marcelwgn
approved these changes
Aug 14, 2021
Microsoft.Toolkit.Uwp.UI.Controls.Primitives/ConstrainedBox/ConstrainedBox.Properties.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4166 too
Adds Value Coercion to the properties to ensure they're within a valid range.
Also fixes the issue with MultipleX/Y not triggering layout updates.
Debating whether to add more tests to this PR or not still... 🤔
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Can specify any values for properties.
What is the new behavior?
Will reset/bound properties to expected values if out-of-range.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information