Fix Windows DrawingView image rendering so exported/rendered strokes use the correct (round) line caps#3216
Merged
TheCodeTraveler merged 2 commits intoMay 11, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Windows DrawingView image rendering so exported/rendered strokes use the correct (round) line caps, addressing the visual artifacts reported in #3215 when LineWidth is large.
Changes:
- Introduced a reusable
CanvasStrokeStyleconfigured with round start/end caps. - Updated Win2D
DrawLinecalls to use the configured stroke style when rendering ink strokes. - Added the required Win2D geometry namespace import.
TheCodeTraveler
approved these changes
May 11, 2026
Collaborator
TheCodeTraveler
left a comment
There was a problem hiding this comment.
Thanks @MFinkBK!
Contributor
Author
|
@TheCodeTraveler You're welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes rendering final image of
DrawingViewthat was using wrong line cap style on Windows.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
No tests, as it can't be tested automatically. No documentation, as it's a bugfix.