Add missing AudioSessionIdChanged stub to android MediaElement#2992
Merged
TheCodeTraveler merged 1 commit intoCommunityToolkit:mainfrom Dec 6, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a missing method stub OnAudioSessionIdChanged(int audioSessionId) to the Android MediaManager's Player.Listener interface implementation to fix a bug where the interface was incomplete.
- Adds the missing
OnAudioSessionIdChangedmethod stub to MediaManager - Follows the existing pattern of empty method implementations for unused Player.Listener callbacks
- Properly placed in alphabetical order among other stub methods
TheCodeTraveler
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Bug Fix
Description of Change
Users have reported a bug that can be fixed by adding another method to
MediaElementstubs forPlayer.ListenerAddingOnAudioSessionIdChanged(int audioSessionId)should fix the linked issue.Linked Issues
OnAudioSessionIdChangedmethod causes AbstractMethodError crash on Android #2989PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information