Bindable property for camera view

Directory.Build.props

@@ -11,6 +11,11 @@
     <AccelerateBuildsInVisualStudio>true</AccelerateBuildsInVisualStudio>
     <GenerateErrorForMissingTargetingPacks>false</GenerateErrorForMissingTargetingPacks>
 
+    <!--Uncomment the lines below if you need to debug the SG code
+If you see any LongPath issue on Windows, check this doc
+https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=cmd#enable-long-paths-in-windows-10-version-1607-and-later-->
+    <!--<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles> -->
+
     <!-- Prevent NuGet Package Vulnerabilities -->
     <NuGetAudit>enable</NuGetAudit>
     <NuGetAuditMode>all</NuGetAuditMode>

samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj

@@ -23,14 +23,6 @@
     <ApplicationDisplayVersion>1.0</ApplicationDisplayVersion>
     <ApplicationVersion>1</ApplicationVersion>
 
-    <!--
-    Uncomment the lines below if you need to debug the SG code
-    If you see any LongPath issue on Windows, check this doc
-    https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=cmd#enable-long-paths-in-windows-10-version-1607-and-later
-    -->
-    <!--<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
-    <CompilerGeneratedFilesOutputPath>$(BaseIntermediateOutputPath)\GeneratedFiles</CompilerGeneratedFilesOutputPath> -->
-
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
 
     <NoWarn>IL2026</NoWarn>

src/CommunityToolkit.Maui.Analyzers.UnitTests/CommunityToolkit.Maui.Analyzers.UnitTests.csproj

@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <TargetFramework>$(NetVersion)</TargetFramework>
-    <EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
     <CompilerGeneratedFilesOutputPath>$(BaseIntermediateOutputPath)\GF</CompilerGeneratedFilesOutputPath>
     <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
     <GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>

src/CommunityToolkit.Maui.Camera/CommunityToolkit.Maui.Camera.csproj

@@ -51,6 +51,10 @@
     <None Include="ReadMe.txt" pack="true" PackagePath="." />
   </ItemGroup>
 
+  <ItemGroup>
+    <ProjectReference Include="..\CommunityToolkit.Maui.SourceGenerators.Internal\CommunityToolkit.Maui.SourceGenerators.Internal.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
+  </ItemGroup>
+
   <ItemGroup Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'android'">
     <!-- Required NuGet Packages -->
     <PackageReference Include="Xamarin.AndroidX.Camera.Camera2" Version="1.4.2.3" />

src/CommunityToolkit.Maui.Camera/Primitives/CameraViewDefaults.shared.cs

@@ -7,7 +7,7 @@ namespace CommunityToolkit.Maui.Core;
 
 /// <summary>Default Values for <see cref="ICameraView"/></summary>
 [EditorBrowsable(EditorBrowsableState.Never)]
-public static class CameraViewDefaults
+static class CameraViewDefaults
 {
 	/// <summary>
 	/// Default value for <see cref="ICameraView.IsAvailable"/>
@@ -38,34 +38,4 @@ public static class CameraViewDefaults
 	/// Default value for <see cref="ICameraView.CameraFlashMode"/>
 	/// </summary>
 	public static CameraFlashMode CameraFlashMode { get; } = CameraFlashMode.Off;
-
-	internal static Command<CancellationToken> CreateCaptureImageCommand(BindableObject bindable)
-	{
-		var cameraView = (CameraView)bindable;
-		return new(async token => await cameraView.CaptureImage(token).ConfigureAwait(false));
-	}
-
-	internal static Command<CancellationToken> CreateStartCameraPreviewCommand(BindableObject bindable)
-	{
-		var cameraView = (CameraView)bindable;
-		return new(async token => await cameraView.StartCameraPreview(token).ConfigureAwait(false));
-	}
-
-	internal static ICommand CreateStopCameraPreviewCommand(BindableObject bindable)
-	{
-		var cameraView = (CameraView)bindable;
-		return new Command(_ => cameraView.StopCameraPreview());
-	}
-
-	internal static Command<Stream> CreateStartVideoRecordingCommand(BindableObject bindable)
-	{
-		var cameraView = (CameraView)bindable;
-		return new Command<Stream>(async stream => await cameraView.StartVideoRecording(stream).ConfigureAwait(false));
-	}
-
-	internal static Command<CancellationToken> CreateStopVideoRecordingCommand(BindableObject bindable)
-	{
-		var cameraView = (CameraView)bindable;
-		return new Command<CancellationToken>(async token => await cameraView.StopVideoRecording(token).ConfigureAwait(false));
-	}
 }

src/CommunityToolkit.Maui.Camera/Views/CameraView.shared.cs

@@ -1,5 +1,4 @@
 using System.ComponentModel;
-using System.Runtime.Versioning;
 using System.Windows.Input;
 using CommunityToolkit.Maui.Core;
 using CommunityToolkit.Maui.Core.Handlers;
@@ -11,82 +10,77 @@
 /// </summary>
 public partial class CameraView : View, ICameraView, IDisposable
 {
-	static readonly BindablePropertyKey isAvailablePropertyKey =
-		BindableProperty.CreateReadOnly(nameof(IsAvailable), typeof(bool), typeof(CameraView), CameraViewDefaults.IsAvailable);
-
 	/// <summary>
-	/// Backing <see cref="BindableProperty"/> for the <see cref="CameraFlashMode"/> property.
+	/// Gets the <see cref="BindableProperty"/> indicating whether the <see cref="IsAvailable"/> is available on the current device.
 	/// </summary>
-	public static readonly BindableProperty CameraFlashModeProperty =
-		BindableProperty.Create(nameof(CameraFlashMode), typeof(CameraFlashMode), typeof(CameraView), CameraViewDefaults.CameraFlashMode);
+	[BindableProperty(DefaultValue = CameraViewDefaults.IsAvailable)]
+	public partial bool IsAvailable { get; }
 
 	/// <summary>
-	/// Backing <see cref="BindableProperty"/> for the <see cref="IsTorchOn"/> property.
+	/// Gets or sets the <see cref="CameraFlashMode"/> property.
 	/// </summary>
-	public static readonly BindableProperty IsTorchOnProperty =
-		BindableProperty.Create(nameof(IsTorchOn), typeof(bool), typeof(CameraView), CameraViewDefaults.IsTorchOn);
+	[BindableProperty(DefaultValue = nameof(CameraViewDefaults.CameraFlashMode))]
+	public partial CameraFlashMode CameraFlashMode { get; set; }
 
 	/// <summary>
-	/// Backing <see cref="BindableProperty"/> for the <see cref="IsAvailable"/> property.
+	/// Gets or sets the <see cref="BindableProperty"/> for the <see cref="IsTorchOn"/> property.
 	/// </summary>
-	public static readonly BindableProperty IsAvailableProperty = isAvailablePropertyKey.BindableProperty;
-
-	static readonly BindablePropertyKey isCameraBusyPropertyKey =
-		BindableProperty.CreateReadOnly(nameof(IsCameraBusy), typeof(bool), typeof(CameraView), CameraViewDefaults.IsCameraBusy);
+	[BindableProperty(DefaultValue = CameraViewDefaults.IsTorchOn)]
+	public partial bool IsTorchOn { get; set; }
 
 	/// <summary>
-	/// Backing <see cref="BindableProperty"/> for the <see cref="IsCameraBusy"/> property.
+	/// Gets the <see cref="BindableProperty"/> for the <see cref="IsCameraBusy"/> property.
 	/// </summary>
-	public static readonly BindableProperty IsCameraBusyProperty = isCameraBusyPropertyKey.BindableProperty;
+	[BindableProperty(DefaultValue = CameraViewDefaults.IsCameraBusy)]
+	public partial bool IsCameraBusy { get; }
 
 	/// <summary>
-	/// Backing <see cref="BindableProperty"/> for the <see cref="SelectedCamera"/> property.
+	/// Gets or sets the <see cref="BindableProperty"/> for the <see cref="SelectedCamera"/> property.
 	/// </summary>
-	public static readonly BindableProperty? SelectedCameraProperty = BindableProperty.Create(nameof(SelectedCamera),
-		typeof(CameraInfo), typeof(CameraView), null, defaultBindingMode: BindingMode.TwoWay);
-
+	[BindableProperty(DefaultBindingMode = BindingMode.TwoWay)]
+	public partial CameraInfo? SelectedCamera { get; set; }
+	
 	/// <summary>
-	/// Backing <see cref="BindableProperty"/> for the <see cref="ZoomFactor"/> property.
+	/// Gets or sets the <see cref="BindableProperty"/> for the <see cref="ZoomFactor"/> property.
 	/// </summary>
-	public static readonly BindableProperty ZoomFactorProperty =
-		BindableProperty.Create(nameof(ZoomFactor), typeof(float), typeof(CameraView), CameraViewDefaults.ZoomFactor, coerceValue: CoerceZoom, defaultBindingMode: BindingMode.TwoWay);
+	[BindableProperty(DefaultValue = CameraViewDefaults.ZoomFactor, DefaultBindingMode = BindingMode.TwoWay, CoerceValueMethodName = nameof(CoerceZoom))]
+	public partial float ZoomFactor { get; set; }
 
 	/// <summary>
-	/// Backing <see cref="BindableProperty"/> for the <see cref="ImageCaptureResolution"/> property.
+	/// Gets or sets the <see cref="BindableProperty"/> for the <see cref="ImageCaptureResolution"/> property.
 	/// </summary>
-	public static readonly BindableProperty ImageCaptureResolutionProperty = BindableProperty.Create(nameof(ImageCaptureResolution),
-		typeof(Size), typeof(CameraView), CameraViewDefaults.ImageCaptureResolution, defaultBindingMode: BindingMode.TwoWay);
+	[BindableProperty(DefaultValueCreatorMethodName = nameof(CreateImageCaptureResolution), DefaultBindingMode = BindingMode.TwoWay)]
+	public partial Microsoft.Maui.Graphics.Size ImageCaptureResolution { get; set; }
 
 	/// <summary>
-	/// Backing BindableProperty for the <see cref="CaptureImageCommand"/> property.
+	/// Gets the <see cref="BindableProperty"/> for the <see cref="CaptureImageCommand"/> property.
 	/// </summary>
-	public static readonly BindableProperty CaptureImageCommandProperty =
-		BindableProperty.CreateReadOnly(nameof(CaptureImageCommand), typeof(Command<CancellationToken>), typeof(CameraView), null, BindingMode.OneWayToSource, defaultValueCreator: CameraViewDefaults.CreateCaptureImageCommand).BindableProperty;
+	[BindableProperty(DefaultValueCreatorMethodName = nameof(CreateCaptureImageCommand), DefaultBindingMode = BindingMode.OneWayToSource)]
+	public partial Command<CancellationToken> CaptureImageCommand { get; }
 
 	/// <summary>
-	/// Backing BindableProperty for the <see cref="StartCameraPreviewCommand"/> property.
+	/// Gets the <see cref="BindableProperty"/> for the <see cref="StartCameraPreviewCommand"/> property.
 	/// </summary>
-	public static readonly BindableProperty StartCameraPreviewCommandProperty =
-		BindableProperty.CreateReadOnly(nameof(StartCameraPreviewCommand), typeof(Command<CancellationToken>), typeof(CameraView), null, BindingMode.OneWayToSource, defaultValueCreator: CameraViewDefaults.CreateStartCameraPreviewCommand).BindableProperty;
+	[BindableProperty(DefaultValueCreatorMethodName = nameof(CreateStartCameraPreviewCommand), DefaultBindingMode = BindingMode.OneWayToSource)]
+	public partial Command<CancellationToken> StartCameraPreviewCommand { get; }
 
 	/// <summary>
-	/// Backing BindableProperty for the <see cref="StopCameraPreviewCommand"/> property.
+	/// Gets the <see cref="BindableProperty"/> for the <see cref="StopCameraPreviewCommand"/> property.
 	/// </summary>
-	public static readonly BindableProperty StopCameraPreviewCommandProperty =
-		BindableProperty.CreateReadOnly(nameof(StopCameraPreviewCommand), typeof(ICommand), typeof(CameraView), null, BindingMode.OneWayToSource, defaultValueCreator: CameraViewDefaults.CreateStopCameraPreviewCommand).BindableProperty;
+	[BindableProperty(DefaultValueCreatorMethodName = nameof(CreateStopCameraPreviewCommand), DefaultBindingMode = BindingMode.OneWayToSource)]
+	public partial Command<CancellationToken> StopCameraPreviewCommand { get; }
 
 	/// <summary>
-	/// Backing BindableProperty for the <see cref="StartVideoRecordingCommand"/> property.
+	/// Gets the <see cref="BindableProperty"/> for the <see cref="StartVideoRecordingCommand"/> property.
 	/// </summary>
-	public static readonly BindableProperty StartVideoRecordingCommandProperty =
-		BindableProperty.CreateReadOnly(nameof(StartVideoRecordingCommand), typeof(Command<Stream>), typeof(CameraView), null, BindingMode.OneWayToSource, defaultValueCreator: CameraViewDefaults.CreateStartVideoRecordingCommand).BindableProperty;
+	[BindableProperty(DefaultValue = nameof(CreateStartVideoRecordingCommand), DefaultBindingMode = BindingMode.OneWayToSource)]
+	public partial Command<Stream> StartVideoRecordingCommand { get; }
 
 	/// <summary>
-	/// Backing BindableProperty for the <see cref="StopVideoRecordingCommand"/> property.
+	/// Gets the <see cref="BindableProperty"/> for the <see cref="StopVideoRecordingCommand"/> property.
 	/// </summary>
-	public static readonly BindableProperty StopVideoRecordingCommandProperty =
-		BindableProperty.CreateReadOnly(nameof(StopVideoRecordingCommand), typeof(Command<CancellationToken>), typeof(CameraView), null, BindingMode.OneWayToSource, defaultValueCreator: CameraViewDefaults.CreateStopVideoRecordingCommand).BindableProperty;
-
+	[BindableProperty(DefaultValue = nameof(CreateStopVideoRecordingCommand), DefaultBindingMode = BindingMode.OneWayToSource)]
+	public partial Command<CancellationToken> StopVideoRecordingCommand { get; }
 
 	readonly SemaphoreSlim captureImageSemaphoreSlim = new(1, 1);
 	readonly WeakEventManager weakEventManager = new();
@@ -114,95 +108,6 @@
 		remove => weakEventManager.RemoveEventHandler(value);
 	}
 
-	/// <summary>
-	/// Gets a value indicating whether the camera feature is available on the current device.
-	/// </summary>
-	public bool IsAvailable => (bool)GetValue(IsAvailableProperty);
-
-	/// <summary>
-	/// Gets a value indicating whether the camera is currently busy.
-	/// </summary>
-	public bool IsCameraBusy => (bool)GetValue(IsCameraBusyProperty);
-
-	/// <summary>
-	/// Gets the Command that triggers an image capture.
-	/// </summary>
-	/// <remarks>
-	/// <see cref="CaptureImageCommand"/> has a <see cref="Type"/> of Command&lt;CancellationToken&gt; which requires a <see cref="CancellationToken"/> as a CommandParameter. See <see cref="Command{CancellationToken}"/> and <see cref="System.Windows.Input.ICommand.Execute(object)"/> for more information on passing a <see cref="CancellationToken"/> into <see cref="Command{T}"/> as a CommandParameter
-	/// </remarks>
-	public Command<CancellationToken> CaptureImageCommand => (Command<CancellationToken>)GetValue(CaptureImageCommandProperty);
-
-	/// <summary>
-	/// Gets the Command that starts the camera preview.
-	/// </summary>
-	/// /// <remarks>
-	/// <see cref="StartCameraPreviewCommand"/> has a <see cref="Type"/> of Command&lt;CancellationToken&gt; which requires a <see cref="CancellationToken"/> as a CommandParameter. See <see cref="Command{CancellationToken}"/> and <see cref="System.Windows.Input.ICommand.Execute(object)"/> for more information on passing a <see cref="CancellationToken"/> into <see cref="Command{T}"/> as a CommandParameter
-	/// </remarks>
-	public Command<CancellationToken> StartCameraPreviewCommand => (Command<CancellationToken>)GetValue(StartCameraPreviewCommandProperty);
-
-	/// <summary>
-	/// Gets the Command that stops the camera preview.
-	/// </summary>
-	public ICommand StopCameraPreviewCommand => (ICommand)GetValue(StopCameraPreviewCommandProperty);
-
-	/// <summary>
-	/// Gets the Command that starts video recording.
-	/// </summary>
-	/// <remarks>
-	/// <see cref="StartVideoRecordingCommand"/> has a <see cref="Type"/> of Command&lt;Stream&gt; which requires a <see cref="Stream"/> as a CommandParameter.
-	/// The <see cref="Stream"/> parameter represents the destination where the recorded video will be saved.
-	/// See <see cref="Command{Stream}"/> and <see cref="System.Windows.Input.ICommand.Execute(object)"/> for more information on passing a <see cref="Stream"/> into <see cref="Command{T}"/> as a CommandParameter.
-	/// </remarks>
-	public Command<Stream> StartVideoRecordingCommand => (Command<Stream>)GetValue(StartVideoRecordingCommandProperty);
-
-	/// <summary>
-	/// Gets the Command that stops video recording.
-	/// </summary>
-	/// <remarks>
-	/// <see cref="StopVideoRecordingCommand"/> has a <see cref="Type"/> of Command&lt;CancellationToken&gt;, which requires a <see cref="CancellationToken"/> as a CommandParameter. 
-	/// See <see cref="Command{CancellationToken}"/> and <see cref="System.Windows.Input.ICommand.Execute(object)"/> for more information on passing a <see cref="CancellationToken"/> into <see cref="Command{T}"/> as a CommandParameter.
-	/// </remarks>
-	public Command<CancellationToken> StopVideoRecordingCommand => (Command<CancellationToken>)GetValue(StopVideoRecordingCommandProperty);
-
-	/// <summary>
-	/// Gets or sets the <see cref="CameraFlashMode"/>.
-	/// </summary>
-	public CameraFlashMode CameraFlashMode
-	{
-		get => (CameraFlashMode)GetValue(CameraFlashModeProperty);
-		set => SetValue(CameraFlashModeProperty, value);
-	}
-
-	/// <inheritdoc cref="ICameraView.SelectedCamera"/>
-	public CameraInfo? SelectedCamera
-	{
-		get => (CameraInfo?)GetValue(SelectedCameraProperty);
-		set => SetValue(SelectedCameraProperty, value);
-	}
-
-	/// <inheritdoc cref="ICameraView.ZoomFactor"/>
-	public float ZoomFactor
-	{
-		get => (float)GetValue(ZoomFactorProperty);
-		set => SetValue(ZoomFactorProperty, value);
-	}
-
-	/// <inheritdoc cref="ICameraView.ImageCaptureResolution"/>
-	public Size ImageCaptureResolution
-	{
-		get => (Size)GetValue(ImageCaptureResolutionProperty);
-		set => SetValue(ImageCaptureResolutionProperty, value);
-	}
-
-	/// <summary>
-	/// Gets or sets a value indicating whether the torch (flash) is on.
-	/// </summary>
-	public bool IsTorchOn
-	{
-		get => (bool)GetValue(IsTorchOnProperty);
-		set => SetValue(IsTorchOnProperty, value);
-	}
-
 	static ICameraProvider CameraProvider => IPlatformApplication.Current?.Services.GetRequiredService<ICameraProvider>() ?? throw new CameraException("Unable to retrieve CameraProvider");
 
 	[EditorBrowsable(EditorBrowsableState.Never)]
@@ -323,16 +228,38 @@
 		}
 	}
 
-	void ICameraView.OnMediaCaptured(Stream imageData)
+	static object CreateImageCaptureResolution(BindableObject bindable) => CameraViewDefaults.ImageCaptureResolution;
+
+	static Command<CancellationToken> CreateCaptureImageCommand(BindableObject bindable)
 	{
-		weakEventManager.HandleEvent(this, new MediaCapturedEventArgs(imageData), nameof(MediaCaptured));
+		var cameraView = (CameraView)bindable;
+		return new(async token => await cameraView.CaptureImage(token).ConfigureAwait(false));
 	}
 
-	void ICameraView.OnMediaCapturedFailed(string failureReason)
+	static Command<CancellationToken> CreateStartCameraPreviewCommand(BindableObject bindable)
 	{
-		weakEventManager.HandleEvent(this, new MediaCaptureFailedEventArgs(failureReason), nameof(MediaCaptureFailed));
+		var cameraView = (CameraView)bindable;
+		return new(async token => await cameraView.StartCameraPreview(token).ConfigureAwait(false));
 	}
 
+	static CCommand CreateStopCameraPreviewCommand(BindableObject bindable)
+	{
+		var cameraView = (CameraView)bindable;
+		return new Command(_ => cameraView.StopCameraPreview());
+	}
+
+	static Command<Stream> CreateStartVideoRecordingCommand(BindableObject bindable)
+	{
+		var cameraView = (CameraView)bindable;
+		return new Command<Stream>(async stream => await cameraView.StartVideoRecording(stream).ConfigureAwait(false));
+	}
+
+	static Command<CancellationToken> CreateStopVideoRecordingCommand(BindableObject bindable)
+	{
+		var cameraView = (CameraView)bindable;
+		return new Command<CancellationToken>(async token => await cameraView.StopVideoRecording(token).ConfigureAwait(false));
+	}
+
 	static object CoerceZoom(BindableObject bindable, object value)
 	{
 		var cameraView = (CameraView)bindable;
@@ -354,4 +281,14 @@
 
 		return input;
 	}
+
+	void ICameraView.OnMediaCaptured(Stream imageData)
+	{
+		weakEventManager.HandleEvent(this, new MediaCapturedEventArgs(imageData), nameof(MediaCaptured));
+	}
+
+	void ICameraView.OnMediaCapturedFailed(string failureReason)
+	{
+		weakEventManager.HandleEvent(this, new MediaCaptureFailedEventArgs(failureReason), nameof(MediaCaptureFailed));
+	}
 }