Skip to content

Add CommunityToolkit.Maui.SourceGenerator.Benchmarks, Reduce Memory Allocations on [BindableProperty] Source Generator#2960

Merged
TheCodeTraveler merged 5 commits intomainfrom
Add-Source-Generator-Benchmarks
Nov 24, 2025
Merged

Add CommunityToolkit.Maui.SourceGenerator.Benchmarks, Reduce Memory Allocations on [BindableProperty] Source Generator#2960
TheCodeTraveler merged 5 commits intomainfrom
Add-Source-Generator-Benchmarks

Conversation

@TheCodeTraveler
Copy link
Collaborator

@TheCodeTraveler TheCodeTraveler commented Nov 22, 2025

Description of Change

This PR adds CommunityToolkit.Maui.SourceGenerator.Benchmarks.csproj and updates the GitHub Action benchmarks.yml.

This PR also optimizes the [BindableProperty] Source Generator to reduce memory allocations.

PR Checklist

Additional information

This PR updates benchmarks.yml to only run on Windows. This was done for two reasons:

  1. We only publish the results from the Windows benchamarks
  2. The Source Generator Benchmarks do not run successfully on macOS

@TheCodeTraveler TheCodeTraveler changed the title Add CommunityToolkit.Maui.SourceGenerator.Benchmarks Add CommunityToolkit.Maui.SourceGenerator.Benchmarks, Reduce Memory Allocations on [BindableProperty] Source Generator Nov 22, 2025
Copy link
Member

@ne0rrmatrix ne0rrmatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go.

@TheCodeTraveler TheCodeTraveler marked this pull request as ready for review November 24, 2025 02:23
@TheCodeTraveler TheCodeTraveler merged commit 7492972 into main Nov 24, 2025
21 of 24 checks passed
@TheCodeTraveler TheCodeTraveler deleted the Add-Source-Generator-Benchmarks branch November 24, 2025 02:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants