Update ColorConversionExtensions.shared.cs#2945
Merged
TheCodeTraveler merged 2 commits intoCommunityToolkit:mainfrom Nov 17, 2025
Merged
Update ColorConversionExtensions.shared.cs#2945TheCodeTraveler merged 2 commits intoCommunityToolkit:mainfrom
TheCodeTraveler merged 2 commits intoCommunityToolkit:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a culture-specific formatting issue in the ToCmykaString() method to ensure consistent behavior across different culture settings.
- Updated
ToCmykaString()to explicitly use the providedCultureInfoparameter for all numeric formatting operations - Replaced interpolated string format specifiers (
:P0) with explicitToString("P0", cultureInfo)calls
TheCodeTraveler
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes a culture-specific formatting issue in the
ToCmykaString()method to ensure consistent behavior across different culture settings.ToCmykaString()to explicitly use the provided CultureInfo parameter for all numeric formatting operations:P0) with explicitToString("P0", cultureInfo)callsLinked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
I forced the CurrentInfo.CurrentCulture to "de-DE" to repro the failing xUnit test problem and applied fixes until the xUnit tests started passing.