Repository navigation
Remove unused Microsoft.Bcl.Memory references - #2567
Merged
aaronpowell merged 1 commit intoNov 18, 2026
Merged
aaronpowell merged 1 commit into
aaronpowell merged 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 2567Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 2567" |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the removal of the unused Meilisearch dependency declarations and central version override.
No open issues 🎉
What changed in this PR
Removes unused Microsoft.Bcl.Memory dependency declarations from the Meilisearch integrations and central package management, avoiding the unnecessary version update discussed in #2459.
Changes:
- Removes explicit package references from both Meilisearch packages.
- Removes the stale central version override.
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Meilisearch/CommunityToolkit.Aspire.Meilisearch.csproj | Removes the client integration’s explicit dependency. |
| src/CommunityToolkit.Aspire.Hosting.Meilisearch/CommunityToolkit.Aspire.Hosting.Meilisearch.csproj | Removes the hosting integration’s explicit dependency. |
| Directory.Packages.props | Removes the unused central version override. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N/A (no associated issue)
Remove the stale
Microsoft.Bcl.Memorycentral version and explicit references from both Meilisearch packages. The current MeiliSearch package no longer depends on it.PR Checklist
Other information
Relates to #2459.
Validation:
dotnet build src\CommunityToolkit.Aspire.Meilisearch\CommunityToolkit.Aspire.Meilisearch.csproj- passed (0 warnings, 0 errors).dotnet build src\CommunityToolkit.Aspire.Hosting.Meilisearch\CommunityToolkit.Aspire.Hosting.Meilisearch.csproj- passed (0 warnings, 0 errors).