Skip to content

Remove explicit Source Link package - #1585

Merged
afscrome merged 1 commit into
mainfrom
codex/remove-explicit-sourcelink
Sep 12, 2026
Merged

afscrome merged 1 commit into
mainfrom
codex/remove-explicit-sourcelink

Conversation

@afscrome

@afscrome afscrome commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Why

Microsoft.SourceLink.GitHub 8.0.0 transitively restores Microsoft.Build.Tasks.Git 8.0.0, which is affected by GHSA-23fw-v26w-5fgq. The .NET SDK has included and enabled Source Link providers for GitHub-hosted SDK-style projects since .NET 8, so this explicit package reference is redundant and overrides the SDK-provided implementation.

Removing the reference lets projects use the SDK-provided Source Link implementation and removes the vulnerable NuGet dependency from restore.

Fixes failures in #1583, #1584 + more

Changes

  • remove the redundant Microsoft.SourceLink.GitHub package reference and central version
  • remove the now-default EmbedUntrackedSources property
  • retain the existing shared PublishRepositoryUrl setting

Validation

Ran:

ext dotnet pack src/CommunityToolkit.Aspire.Hosting.Adminer/CommunityToolkit.Aspire.Hosting.Adminer.csproj --configuration Release --output <temp>

The package built successfully for
et8.0,
et9.0, and
et10.0. Inspected the resulting .nupkg and confirmed its nuspec still contains the Git repository URL, branch, and commit. Also confirmed the built
et10.0 assembly contains the GitHub Source Link mapping.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocking-clean-ci Blocking a green CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants