Repository navigation
Remove explicit Source Link package - #1585
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Microsoft.SourceLink.GitHub 8.0.0 transitively restores Microsoft.Build.Tasks.Git 8.0.0, which is affected by GHSA-23fw-v26w-5fgq. The .NET SDK has included and enabled Source Link providers for GitHub-hosted SDK-style projects since .NET 8, so this explicit package reference is redundant and overrides the SDK-provided implementation.
Removing the reference lets projects use the SDK-provided Source Link implementation and removes the vulnerable NuGet dependency from restore.
Fixes failures in #1583, #1584 + more
Changes
Validation
Ran:
ext dotnet pack src/CommunityToolkit.Aspire.Hosting.Adminer/CommunityToolkit.Aspire.Hosting.Adminer.csproj --configuration Release --output <temp>The package built successfully for
et8.0,
et9.0, and
et10.0. Inspected the resulting .nupkg and confirmed its nuspec still contains the Git repository URL, branch, and commit. Also confirmed the built
et10.0 assembly contains the GitHub Source Link mapping.