Aspire-13.1 #1056
Merged
Aspire-13.1 #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… methods - Updated multiple test files to replace calls to GetEnvironmentVariableValuesAsync() with GetEnvironmentVariablesAsync(). - Replaced calls to GetArgumentValuesAsync() with GetArgumentListAsync() in various test cases. - Introduced new utility methods in the CommunityToolkit.Aspire.Testing namespace for better argument and environment variable handling.
10 tasks
Updated infrastructure and test code to use Azure Redis Enterprise (Microsoft.Cache/redisEnterprise) instead of the legacy Azure Redis Cache. Refactored connection string handling and key retrieval to use RedisEnterpriseCluster and RedisEnterpriseDatabase resources. Updated Bicep templates and test assertions accordingly. Removed obsolete test for non-SSL port, as Redis Enterprise always requires TLS. This modernizes the codebase to align with current Azure recommendations.
aaronpowell
requested review from
Alirexaa,
ErikEJ,
FullStackChef,
Harold-Morgan,
MichielBrys,
WhitWaldo,
esskar,
jmezach,
martinjt,
paule96,
shiranshalom and
tommasodotNET
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Aspire Community Toolkit to use .NET Aspire 13.1.0, introducing new testing utilities and migrating from Azure Redis Cache to Azure Managed Redis Enterprise.
Changes:
- Upgraded Aspire SDK from 13.0.0 to 13.1.0 across all project files
- Introduced utility methods
GetEnvironmentVariablesAsync()andGetArgumentListAsync()in theCommunityToolkit.Aspire.Testingnamespace to simplify test code - Migrated Azure Dapr Redis integration from Azure Redis Cache to Azure Managed Redis Enterprise
Reviewed changes
Copilot reviewed 75 out of 75 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/CommunityToolkit.Aspire.Testing/EnvironmentVariableEvaluator.cs | New utility class for evaluating environment variables in tests |
| tests/CommunityToolkit.Aspire.Testing/ArgumentEvaluator.cs | New utility class for evaluating command-line arguments in tests |
| tests/CommunityToolkit.Aspire.Testing/CommunityToolkit.Aspire.Testing.csproj | Updated Aspire SDK version to 13.1.0 |
| Multiple test files | Replaced direct calls with new utility methods for cleaner test code |
| tests/CommunityToolkit.Aspire.Hosting.Keycloak.Extensions.Tests/*.cs | Updated to manually process environment callback annotations instead of using utility methods |
| src/CommunityToolkit.Aspire.Hosting.Azure.Dapr.Redis/AzureRedisCacheDaprHostingExtensions.cs | Migrated from Azure Redis Cache to Azure Managed Redis Enterprise with updated resource types and connection handling |
| tests/CommunityToolkit.Aspire.Hosting.Azure.Dapr.Redis.Tests/ResourceCreationTests.cs | Updated tests to reflect Redis Enterprise migration and removed obsolete TLS test |
| Directory.Build.props | Updated Aspire version to 13.1.0 and other dependency versions |
| Directory.Packages.props | Fixed Keycloak package version format and updated OllamaSharp version |
| nuget.config | Added dotnet9 package source |
| All example AppHost .csproj files | Updated Aspire.AppHost.Sdk version to 13.1.0 |
| examples/dapr/CommunityToolkit.Aspire.Hosting.Azure.Dapr.AppHost/Program.cs | Updated to use AddAzureManagedRedis instead of AddAzureRedis |
| .github/agents/hosting-integration-creator.agent.md | Formatting improvements for list items |
Comments suppressed due to low confidence (1)
tests/CommunityToolkit.Aspire.Hosting.Azure.Dapr.Tests/AzureDaprPublishingHelperTests.cs:53
- This assignment to redisState is useless, since its value is never read.
Comment on lines
+11
to
+14
| public static async ValueTask<Dictionary<string, string>> GetEnvironmentVariablesAsync( | ||
| this IResource resource, | ||
| DistributedApplicationOperation applicationOperation = DistributedApplicationOperation.Run, | ||
| IServiceProvider? serviceProvider = null) |
There was a problem hiding this comment.
The public method GetEnvironmentVariablesAsync is missing XML documentation comments. According to the project's coding guidelines, all public members require XML doc comments.
|
|
||
| public static class ArgumentEvaluator | ||
| { | ||
| public static async ValueTask<List<string>> GetArgumentListAsync(this IResource resource, IServiceProvider? serviceProvider = null) |
There was a problem hiding this comment.
The public method GetArgumentListAsync is missing XML documentation comments. According to the project's coding guidelines, all public members require XML doc comments.
| redisBuilder.ConfigureInfrastructure(infrastructure => | ||
| { | ||
| var redisResource = infrastructure.GetProvisionableResources().OfType<AzureRedisResource>().SingleOrDefault(); | ||
| var redisDatabase = infrastructure.GetProvisionableResources().OfType<RedisEnterpriseDatabase>().SingleOrDefault(); |
There was a problem hiding this comment.
This assignment to redisDatabase is useless, since its value is never read.
| using var builder = TestDistributedApplicationBuilder.Create(DistributedApplicationOperation.Publish); | ||
|
|
||
| var redisState = builder.AddAzureRedis("redisState").RunAsContainer(); | ||
| var redisState = builder.AddAzureManagedRedis("redisState").RunAsContainer(); |
There was a problem hiding this comment.
This assignment to redisState is useless, since its value is never read.
This issue also appears in the following locations of the same file:
- line 53
This is from discussion with @FullStackChef as the test could be indicating something underlying but we can't figure out what so making the packages 'not stable' as a warning to users
ErikEJ
approved these changes
Jan 12, 2026
tommasodotNET
approved these changes
Jan 12, 2026
Harold-Morgan
approved these changes
Jan 12, 2026
Contributor
Minimum allowed line rate is |
aaronpowell
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
aaronpowell
requested review from
aviv86,
karmeli87 and
ppekrol
as code owners
This was referenced Jan 14, 2026
Bump CommunityToolkit.Aspire.Hosting.Flagd from 13.0.0 to 13.1.0
askpt/openfeature-aspire-sample#270
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
PR Checklist
Other information