Skip to content

Conversation

@jclapis
Copy link
Collaborator

@jclapis jclapis commented Jun 10, 2025

This is a fairly large PR that addresses numerous issues with the way external HTTP requests are handled:

  • Enforces that https is used as the scheme of any endpoints to prevent man-in-the-middle listeners
  • Adds a configurable timeout so requests don't run indefinitely
  • Reads response bodies in chunks instead of loading them all directly into memory before using them
    • Prevents handling if the Content-Length header is too large
    • If it's missing, stops if reading the response body has exceeded a size threshold (currently 10 MB)

This also modifies the SSV loader tests to use a local server with a captured (good) response instead of the canoncial SSV server.

ltitanb and others added 30 commits May 13, 2025 17:17
@jclapis jclapis self-assigned this Jun 10, 2025
@jclapis jclapis added the pbs Pbs module / Builder API label Jun 10, 2025
@jclapis jclapis marked this pull request as ready for review July 7, 2025 21:40
@ltitanb ltitanb requested a review from ManuelBilbao July 8, 2025 19:40
@ltitanb ltitanb merged commit 2f785d1 into main Jul 11, 2025
2 of 3 checks passed
@ltitanb ltitanb deleted the improve-http-handling branch July 11, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pbs Pbs module / Builder API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants