CBST2-11: Improve path validation on local Mux keys loader #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltitanb
requested changes
Jun 6, 2025
Collaborator
ltitanb
left a comment
ltitanb
left a comment
There was a problem hiding this comment.
can we change this to return a Result<Option<_ instead? the handle_docker_init already returns a result so we can avoid rogue panics around
jclapis
reviewed
Jul 7, 2025
jclapis
reviewed
Jul 8, 2025
Co-authored-by: Joe Clapis <[email protected]>
ltitanb
approved these changes
Jul 8, 2025
jclapis
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the passed file exists and has
.jsonextension