Skip to content

Conversation

@fbernardo
Copy link
Contributor

@fbernardo fbernardo commented Jun 12, 2024

Description

This PR fixes a compilation error in Xcode 16 Beta compiling against the tvOS 18 SDK:

/mamba/mambaSharedFramework/Rapid Parser/RapidParserNewTagCallbacks.h:25:53: Missing '#include <_types/_uint64_t.h>'; 'uint64_t' must be declared before it is used

Change Notes

  • Added the necessary <stdint.h> import where it is used.

Pre-submission Checklist

  • I ran the unit tests locally before checking in.
  • I made sure there were no compiler warnings before checking in.
  • I have written useful documentation for all public code.
  • I have written unit tests for this new feature.

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2024

CLA assistant check
All committers have signed the CLA.

@MKW11
Copy link

MKW11 commented Jul 16, 2024

Hey Guys! Is it possible to merge and release this? We could very much use it at Sky and NBC for some testing. As there is no SPM file on this repository, we can only import it via official release.
If you prefer this import be conditional, as the XCode 16 has not been released yet, please let me recommend the following:

#if __clang_major__ >= 16
    #include <stdint.h>
#endif

Thank you for your kind consideration.

@rmigneco rmigneco merged commit cd65779 into Comcast:develop Jul 17, 2024
@fbernardo fbernardo deleted the fix/fbernardo/xcode_16_compilation_error branch July 17, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants