Skip to content

fix(ci): bump pnpm/action-setup for pnpm 12 on Windows - #955

Merged
rinchen merged 1 commit into
mainfrom
fix/ci-pnpm12-action-setup
Sep 8, 2026
Merged

rinchen merged 1 commit into
mainfrom
fix/ci-pnpm12-action-setup

Conversation

@rinchen

@rinchen rinchen commented Sep 8, 2026

Copy link
Copy Markdown
Member

Summary

  • Windows build failed right after the pnpm 12 merge when actions/setup-node ran pnpm store path against a broken legacy @pnpm/exe shim path under setup-pnpm (PNPM_HOME v10 vs v11 layout warning + "…\pnpm\pnpm" is not recognized).
  • Bump pnpm/action-setup to v6.1.0 (ea17c68…), which adds native pnpm 12 bootstrap (see pnpm/action-setup#288), across the composite action and workflows that still pin the action directly.
  • Update the CI workflow contract test pin.

Test plan

  • pnpm exec vitest run scripts/ci-workflows.test.mjs
  • Re-run Build (or this PR’s CI) and confirm Windows Install Node.js / Setup Node succeeds with cache: pnpm
  • Confirm macOS/Linux install steps still pass with the same pin

Windows setup-node cache failed on broken legacy @pnpm/exe shims after the
pnpm 12 upgrade; v6.1.0 uses the native bootstrap.
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 25 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Advanced

Run ID: c3067a5c-59b4-45d1-91c9-c593a9a9c0e2

📥 Commits

Reviewing files that changed from the base of the PR and between 51431f3 and b4a4f48.

📒 Files selected for processing (8)
  • .github/actions/setup-node-pnpm/action.yaml
  • .github/workflows/build.yaml
  • .github/workflows/buttonmash.yaml
  • .github/workflows/cut-release.yaml
  • .github/workflows/e2e.yaml
  • .github/workflows/release.yaml
  • .github/workflows/third-party-licenses.yaml
  • scripts/ci-workflows.test.mjs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rinchen
rinchen merged commit 0511e1d into main Sep 8, 2026
18 checks passed
@rinchen
rinchen deleted the fix/ci-pnpm12-action-setup branch September 8, 2026 12:49
@rinchen rinchen added the bug Something isn't working as expected label Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant