Skip to content
This repository was archived by the owner on May 3, 2019. It is now read-only.

Feature pocketcasts plugin#117

Merged
ColinDuquesnoy merged 2 commits into
ColinDuquesnoy:developfrom
lkstz:feature-pocketcasts-plugin
Sep 17, 2017
Merged

Feature pocketcasts plugin#117
ColinDuquesnoy merged 2 commits into
ColinDuquesnoy:developfrom
lkstz:feature-pocketcasts-plugin

Conversation

@lkstz

@lkstz lkstz commented Sep 16, 2017

Copy link
Copy Markdown
Contributor

This PR adds support for the Pocket Casts web player, a popular podcast player.
The web player is built with AngularJS, which makes implementing the required functions very easy.

I modified the original Pocket Casts logo SVG slightly, so that it fits into the application. All rights belong to the original authors.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 92.864% when pulling 72386ed on kolletzki:feature-pocketcasts-plugin into f81d739 on ColinDuquesnoy:develop.

@ColinDuquesnoy ColinDuquesnoy merged commit 66cfd08 into ColinDuquesnoy:develop Sep 17, 2017
@ColinDuquesnoy

Copy link
Copy Markdown
Owner

Thank you!

According to issue #112, this service require proprietary codecs. Can you confirm this? I'll change the plugin metadata accordingly.

ColinDuquesnoy added a commit that referenced this pull request Sep 17, 2017
Improvement useful for the pocketcast plugin, see #117
@lkstz

lkstz commented Sep 18, 2017

Copy link
Copy Markdown
Contributor Author

Yes, Pocket Casts is streaming MP3. Since I'm on Arch Linux, I forgot to set this in the metadata.

@ColinDuquesnoy

Copy link
Copy Markdown
Owner

@kolletzki Thank you for confirming.

Since I'm on Arch Linux, I forgot to set this in the metadata.

Don't worry, I already changed it and it's my fault if the wizard did not ask you the question about proprietary codecs. It will be different in next release.

@ZeroDot1

Copy link
Copy Markdown
Contributor

Web Player 2.0 Beta: https://blog.shiftyjelly.com/2017/09/25/web-player-2-0-beta/
https://playbeta.pocketcasts.com/

@lkstz

lkstz commented Sep 26, 2017

Copy link
Copy Markdown
Contributor Author

Thanks, this looks great. I’ll have a technical look at the new web player in a few days.

@lkstz lkstz deleted the feature-pocketcasts-plugin branch March 7, 2018 09:29
@cpjeanpaul cpjeanpaul mentioned this pull request Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants