feat(search-page): extend search to command arguments and property values, display more choices, and allow list wrapping#13
Open
TheJYU wants to merge 4 commits intoCogentRedTester:masterfrom
Open
Conversation
set wrap=yes in search-page.conf to enable list wrapping in search results.
Previously, the script only searches the name of commands. This commit extends the search to also search command arguments and their types.
Previously, the script only searches the name of properties. This commit extends the search to also search property values.
Options of type "Object settings list" (e.g. vo, ao, vf, af) return a valid choices string via mp.get_property_osd("option-info/<name>/choices"), even though their type is not "Choice".
This commit updates the logic to display choices whenever the choices string is not empty, rather than only when the option type is "Choice".
`type == "Choice" or type == "Object settings list"` could also work, but I think `choices ~= ""` is more elegant and future‑proof.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists of several new improvements.
wrap=yesin search-page.conf to enable).For example, we can search for commands that take a "filename" argument,
or commands that take a "time" type argument,
or properties with a value containing "7z",
and the choices for "af" which were previously missing, are now displayed correctly.
