Skip to content

refactor: init only for web, no check platform #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reslear merged 2 commits into from
Aug 17, 2021
Merged

refactor: init only for web, no check platform #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2ddd59
refactor: usage `init` only for web
reslear Aug 7, 2021
b887bc8
refactor: add android `init` unimplemented
reslear Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions android/src/main/java/com/codetrixstudio/capacitor/GoogleAuth/GoogleAuth.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ public void load() {
googleSignInClient = GoogleSignIn.getClient(this.getContext(), googleSignInOptions);
}

@PluginMethod
public void init(PluginCall call) {
call.unimplemented();
}

@PluginMethod()
public void signIn(PluginCall call) {
saveCall(call);
Expand Down
1 change: 1 addition & 0 deletions ios/Plugin/Plugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@
CAP_PLUGIN_METHOD(signIn, CAPPluginReturnPromise);
CAP_PLUGIN_METHOD(refresh, CAPPluginReturnPromise);
CAP_PLUGIN_METHOD(signOut, CAPPluginReturnPromise);
CAP_PLUGIN_METHOD(init, CAPPluginReturnPromise);
)
5 changes: 5 additions & 0 deletions ios/Plugin/Plugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ public class GoogleAuth: CAPPlugin {
NotificationCenter.default.addObserver(self, selector: #selector(handleOpenUrl(_ :)), name: Notification.Name(CAPNotifications.URLOpen.name()), object: nil);
}

@objc
func init(_ call: CAPPluginCall) {
call.unimplemented("Not available on iOS")
}

@objc
func signIn(_ call: CAPPluginCall) {
signInCall = call;
Expand Down