rm duplicate activated.tag(s)

[looseyi]

cause new PossibilityState already push the state.

state.activated.tag(state)

[dnkoutso]

any tests to add here or do existing ones cover this?

[dnkoutso]

Is there a test case we can add here or do existing ones cover this? Or was it just not used?

Should we also add a CHANGELOG entry?

[looseyi]

there is not need to add new test case, just rm origin duplicate adding tags

…

On Tue, 10 Aug 2021 at 00:41, Dimitris Koutsogiorgas < ***@***.***> wrote: Is there a test case we can add here or do existing ones cover this? Or was it just not used? Should we also add a CHANGELOG entry? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#153 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGGIWEJ625PWPSRAMHZO6LT4AAL3ANCNFSM4XWRGWUA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[deivid-rodriguez]

Makes sense to me, although not sure how to cover this with a fix. It's just duplicated work already done by state.pop_possibility_state. Also, I think state.pop_possibility_state always instantiates a new possibility state, so the if is unnecessary too?