Revert to .NET Framework#13
Conversation
|
TODO:
|
CnCNet.LauncherStub.csproj
Outdated
| <PropertyGroup> | ||
| <TargetFramework>net471</TargetFramework> | ||
| <LangVersion>11.0</LangVersion> | ||
| <TargetFrameworks>net40; net45; net471</TargetFrameworks> |
There was a problem hiding this comment.
Hmm is there any reason for all those old frameworks and not just net48?
There was a problem hiding this comment.
And if it relies on 4.0, is there a need to compile anything else?
There was a problem hiding this comment.
the launcher prompts users about missing frameworks. Win7 comes with net35 (due to the need of accessing registry in 32bit view, the launcher cannot be downgraded to that old), while Windows 10 only comes with net46.
There was a problem hiding this comment.
Is there any benefit in compiling multiple versions then? I think we could settle on one version that fits the most and leave it at that.
There was a problem hiding this comment.
.net 4.0 does have limitations, for example the launcher can not differ amd64 from arm64. This is brought by net45. So that's why I reserved other two frameworks versions in case we need to upgrade the framework for some reasons, for example if Qualcomm’s processors would being popular in laptops someday
There was a problem hiding this comment.
I don't care about win8 users. Just wondering if there are some win7 users that only have .net 4.0 installed?
There was a problem hiding this comment.
I know only that net40 came as an update to Win7. Also Win8 has net45 bundled.
There was a problem hiding this comment.
Either way, I am fine with either.
There was a problem hiding this comment.
I remembered wrong. arm64 detection was supported on net471. So we should leave net40 as the default which is already done in GitHub CI
There was a problem hiding this comment.
I am in favor of <TargetFrameworks>net40; net471</TargetFrameworks> over <TargetFramework>net40</TargetFramework> in case someone needs it for ARM64. The GitHub CI has been configured to compile net40 only, providing binary for downloads in Release
3 participants
This PR migrates the launcher to support .NET 4.8 + .NET 8 client.
The minimum .NET Framework requirement for the launcher is downgraded to 4.0.