feat: implement Label element for form control captions#211
Merged
Conversation
jverkoey
reviewed
Aug 26, 2025
| /// - Parameters: | ||
| /// - text: The text content of the label. | ||
| /// - htmlFor: The id of the form control that this label is associated with. | ||
| public init(_ text: String, htmlFor: String? = nil) where Content == DOMString { |
Collaborator
There was a problem hiding this comment.
I suppose we can't use for: here due to it being a keyword yeah?
Contributor
Author
There was a problem hiding this comment.
Yes, but I just refactored it to be an argument label now instead.
Collaborator
|
Thank you for adding this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially adresses #25
⚡ Summary
This PR implements a
Labelelement for form control captions in Slipstream, based on the existingButton.swiftimplementation. I am using it for a mobile menu toggle implemented with CSS only on a dev website.Includes:
Labelelement supporting static text or custom content via@ViewBuilder.htmlFor.htmlForusage, and a mobile menu toggle scenario.☑️ Checklist