remove try/catch from ~PooledConnection

[mstetsyuk]

Changelog category (leave one):

• Not for changelog (changelog entry is not required)

[clickhouse-gh]

Workflow [PR], commit [51eae77]

Summary: ✅

[Copilot]

Pull Request Overview

This PR removes the try-catch block from the ~PooledConnection() destructor, eliminating the exception handling that was previously suppressing and logging any exceptions thrown during connection cleanup.

Key Changes:

• Removed try-catch wrapper from the destructor body
• Eliminated the tryLogCurrentException call that was logging caught exceptions

[Copilot]

Removing the try-catch block from a destructor is risky because destructors are implicitly noexcept in C++11 and later. If any exception is thrown during the cleanup operations (e.g., from response_stream operations or metrics updates), the program will call std::terminate() and crash. Consider either keeping the try-catch to handle exceptions gracefully, or ensure all operations within the destructor are guaranteed not to throw.

[CheSema]

Adding try catch in every d-tors makes a noise.
You mute exception in d-tor not by choice but out of necessity, as a result you mute an undefined wide set of exceptions. Much better approach is to guarantee that all actions in d-tor are not able to throw.

[rienath]

raufsdunamalijevs@Raufs-Macbook trash % dataplanectl cidb find pr 88668

    PR  CURRENT REPO PR  UPSTREAM REPO PR  VERSION       COMMIT                                    GIT REF      
 88668                   ✅                25.10.1.5838  56f27aa1de46842d12ced000a086badcb438f1dd  master       
 88668                   ✅                25.8.1.8538   749cae4f85a99b5aa280cbf4c65bf9ffd18ffe5c  release/25.8 

raufsdunamalijevs@Raufs-Macbook trash % dataplanectl cidb find pr 89090 


    PR  CURRENT REPO PR  UPSTREAM REPO PR  VERSION      COMMIT                                    GIT REF 
 89090                   ✅                25.11.1.704  33de285cfe44fad60314af3541d9c282a458aad4  master  

Let's backport this to every release where #88668 exists