-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix stress test: check if storage shutdown before we operate MergeTreeDeduplicationLog #52623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stress test: check if storage shutdown before we operate MergeTreeDeduplicationLog #52623
Conversation
|
This is an automated comment for commit 9488567 with description of existing statuses. It's updated for the latest CI running
|
| if (stopped) | ||
| { | ||
| LOG_ERROR(&Poco::Logger::get("MergeTreeDeduplicationLog"), "Storage has been shutdown when we add this part."); | ||
| return {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this block be committed after this? Should we throw an exception instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it's better to throw exception here. Which errorcode do you think is ok to throw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UNFINISHED or ABORTED
Co-authored-by: Alexander Tokmakov <[email protected]>
…eduplicationLog Fix stress test: check if storage shutdown before we operate MergeTreeDeduplicationLog
…ess_test_storage_shutdown_in_mergetreededuplicationlog 23.3 Backport of ClickHouse#52623 - Fix stress test: check if storage shutdown before we operate MergeTreeDeduplicationLog
…eduplicationLog Fix stress test: check if storage shutdown before we operate MergeTreeDeduplicationLog
…ess_test_storage_shutdown_in_mergetreededuplicationlog 23.3 Backport of ClickHouse#52623 - Fix stress test: check if storage shutdown before we operate `MergeTreeDeduplicationLog`
fix ci #47641
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes