Skip to content

Conversation

@hanfei1991
Copy link
Member

fix ci #47641

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@hanfei1991 hanfei1991 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 26, 2023
@robot-clickhouse
Copy link
Member

robot-clickhouse commented Jul 26, 2023

This is an automated comment for commit 9488567 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 error

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 error
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@hanfei1991 hanfei1991 changed the title check if storage shutdown before we operate MergeTreeDeduplicationLog fix stress test: check if storage shutdown before we operate MergeTreeDeduplicationLog Jul 27, 2023
@hanfei1991 hanfei1991 changed the title fix stress test: check if storage shutdown before we operate MergeTreeDeduplicationLog Fix stress test: check if storage shutdown before we operate MergeTreeDeduplicationLog Jul 27, 2023
Comment on lines 236 to 239
if (stopped)
{
LOG_ERROR(&Poco::Logger::get("MergeTreeDeduplicationLog"), "Storage has been shutdown when we add this part.");
return {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this block be committed after this? Should we throw an exception instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's better to throw exception here. Which errorcode do you think is ok to throw?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNFINISHED or ABORTED

@tavplubix tavplubix self-assigned this Jul 27, 2023
@hanfei1991 hanfei1991 merged commit 4f9075e into ClickHouse:master Jul 27, 2023
@hanfei1991 hanfei1991 deleted the hanfei/MergeTreeDeduplicationLog branch July 27, 2023 18:50
ilejn pushed a commit to Altinity/ClickHouse that referenced this pull request Oct 19, 2023
…eduplicationLog

Fix stress test: check if storage shutdown before we operate MergeTreeDeduplicationLog
Enmk added a commit to Altinity/ClickHouse that referenced this pull request Feb 6, 2024
…ess_test_storage_shutdown_in_mergetreededuplicationlog

23.3 Backport of ClickHouse#52623 - Fix stress test: check if storage shutdown before we operate MergeTreeDeduplicationLog
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Feb 8, 2024
…eduplicationLog

Fix stress test: check if storage shutdown before we operate MergeTreeDeduplicationLog
Enmk added a commit to Altinity/ClickHouse that referenced this pull request Feb 9, 2024
…ess_test_storage_shutdown_in_mergetreededuplicationlog

23.3 Backport of ClickHouse#52623 - Fix stress test: check if storage shutdown before we operate `MergeTreeDeduplicationLog`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants