Replace MemoryTrackerBlockerInThread to LockMemoryExceptionInThread #39619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n some places. Reduced MemoryTrackerBlockerInThread level to User.
robot-ch-test-poll
added
the
pr-not-for-changelog
tavplubix
approved these changes
Jul 26, 2022
Member
tavplubix
left a comment
tavplubix
left a comment
There was a problem hiding this comment.
LGTM, but consider making ctor that takes VariableContext private, and pass VariableContext::Global from MemoryTracker only
tavplubix
added
the
pr-must-backport
This was referenced Jul 27, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2022
…MemoryExceptionInThread
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2022
…MemoryExceptionInThread
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2022
…MemoryExceptionInThread
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2022
…MemoryExceptionInThread
robot-clickhouse
added
the
pr-backports-created
tavplubix
added a commit
that referenced
this pull request
Jul 28, 2022
Backport #39619 to 22.7: Replace MemoryTrackerBlockerInThread to LockMemoryExceptionInThread
KochetovNicolai
added a commit
that referenced
this pull request
Aug 1, 2022
Backport #39619 to 22.3: Replace MemoryTrackerBlockerInThread to LockMemoryExceptionInThread
KochetovNicolai
added a commit
that referenced
this pull request
Aug 1, 2022
Backport #39619 to 22.5: Replace MemoryTrackerBlockerInThread to LockMemoryExceptionInThread
KochetovNicolai
added a commit
that referenced
this pull request
Aug 1, 2022
Backport #39619 to 22.6: Replace MemoryTrackerBlockerInThread to LockMemoryExceptionInThread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Replace MemoryTrackerBlockerInThread to LockMemoryExceptionInThread in some places. Reduced MemoryTrackerBlockerInThread level to User.