Misc cmake cleanup #37169
Merged
Misc cmake cleanup #37169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll2
added
the
submodule changed
robot-ch-test-poll1
added
the
pr-build
rschu1ze
force-pushed
the
cmake-cleanup
branch
6 times, most recently
from
f61eb48 to
8650e43
Compare
alexey-milovidov
approved these changes
May 13, 2022
Both are equivalent and removing the duplication was a leftover of PR #36614
- Variable CMAKE_BUILD_COLOR_MAKEFILE has no effect (perhaps it had in ancient CMake), the actual variable is called CMAKE_COLOR_MAKEFILE
Looks like an unused leftover
The module path makes CMake find scripts in directories without
directory qualification, e.g.
include (tools)
instead of
include (cmake/tools.cmake)
The latter is a little bit longer but less ambiguous (imho). Therefore,
removing CMAKE_MODULE_PATH. Note that it pointed to a non-existing
directory anyways ...
As far as I see these were necessary for super old Cmake versions and when contrib libraries (snappy, re2, google test) were still unbundled.
CMake will translate this to a compiler-specific flag to pass the flags to the linker, e.g. for Clang: "-Xlinker", for GCC: "-Wl,". It worked so far because Clang supports -Wl in the meantime too but we should prefer the portable method.
yokofly
added a commit
to timeplus-io/proton
that referenced
this pull request
Oct 22, 2023
ld: warning: -undefined error is deprecated porting missing code line in ClickHouse/ClickHouse#37169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some random build script fixes done when teaching myself cmake for an issue.
See commit msgs of individual commits for details.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):