Skip to content

Fix PIFlushWorkInstrumentationTest compile error.#1006

Merged
CTLalit merged 2 commits into
developfrom
fix/instrumentation_tests
May 19, 2026
Merged

Fix PIFlushWorkInstrumentationTest compile error.#1006
CTLalit merged 2 commits into
developfrom
fix/instrumentation_tests

Conversation

@piyush-kukadiya
Copy link
Copy Markdown
Contributor

@piyush-kukadiya piyush-kukadiya commented May 18, 2026

Summary by CodeRabbit

  • Tests
    • Updated instrumentation tests for notification handling to improve test robustness and accuracy.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ded6faaa-fa26-452b-ab17-2ea9aa584b38

📥 Commits

Reviewing files that changed from the base of the PR and between 01e8640 and 88a98bd.

📒 Files selected for processing (1)
  • clevertap-core/src/androidTest/kotlin/PIFlushWorkInstrumentationTest.kt

Walkthrough

The PR updates PIFlushWorkInstrumentationTest to properly convert notification Bundle objects to JSON format before validation. The test now imports wzrkBundleToJson, updates a test data field, and applies the conversion transformation to notification Bundles during event construction.

Changes

Notification Event JSON Validation

Layer / File(s) Summary
Bundle to JSON conversion in notification test
clevertap-core/src/androidTest/kotlin/PIFlushWorkInstrumentationTest.kt
Import wzrkBundleToJson, update the test nt field value, and convert notification Bundle to JSON via wzrkBundleToJson(it.second) before passing to notificationViewedJson for validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • CTLalit
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing a compile error in PIFlushWorkInstrumentationTest by updating the test to use wzrkBundleToJson transformation.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/instrumentation_tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@francispereira
Copy link
Copy Markdown

francispereira commented May 18, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@piyush-kukadiya piyush-kukadiya changed the base branch from task/release/core/8.2.0 to develop May 18, 2026 12:26
@CTLalit CTLalit merged commit bfe7d50 into develop May 19, 2026
9 checks passed
@CTLalit CTLalit deleted the fix/instrumentation_tests branch May 19, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants