Skip to content

Conversation

@YaoTingYao
Copy link
Member

@YaoTingYao YaoTingYao commented Mar 19, 2025

Response to Issue #62. This PR includes:

1. Updates to at_pre_vp_screen.ui:

  • Removed the "Length of the VP in years" input to avoid user confusion.
  • Renamed "Expected Jurisdictional Activity" to "Expected Annual Jurisdictional Deforestation Rate (ha/year)"

2. Code Cleanup:

  • Removed self.time and its related function in UDef-ARP.py
  • Removed the time parameter and its related functions in allocation_tool.py

Response to Issue #62: UI file updates:

1. Removed the "Length of the VP in years" input to avoid user confusion.
2. Renamed "Expected Jurisdictional Activity" to "Expected Annual Jurisdictional Activity (ha/year).
@YaoTingYao YaoTingYao requested a review from agcopenhaver March 19, 2025 13:20
Copy link
Collaborator

@agcopenhaver agcopenhaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor changes suggested. Feel free to keep as-is if preferred.

YaoTingYao and others added 3 commits March 24, 2025 14:17
Renamed "expected annual jurisdictional activity" to "expected annual jurisdictional deforestation rate (ha/year)" for clarity.

Co-authored-by: Andrew Copenhaver <[email protected]>
Rename label “Expected Annual Jurisdictional Activity (ha/year)” to “Expected Annual Jurisdictional Deforestation Rate (ha/year)” for clarity.

Co-authored-by: Andrew Copenhaver <[email protected]>
Rename “Expected annual jurisdictional activity” to "Expected annual jurisdictional deforestation rate” for clarify.

Co-authored-by: Andrew Copenhaver <[email protected]>
@YaoTingYao
Copy link
Member Author

@agcopenhaver, thanks for the feedback! The suggested change has been incorporated into both the script and the ui. Please let me know if there's anything else needed to be revised. Cheers!

@YaoTingYao YaoTingYao added the enhancement New feature or request label Mar 24, 2025
@YaoTingYao YaoTingYao changed the title Change "Expected Jurisdictional Activity" to "Expected Annual Jurisdictional Activity" Change "Expected Jurisdictional Activity" to "Expected Annual Jurisdictional Deforestation Rate (ha/year)" Mar 24, 2025
@YaoTingYao YaoTingYao merged commit 2b3e9a7 into main Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants