Fixed Adjusted Relative Frequency Table Issue in allocation_tool.py #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where bins are missing during the prediction phase, the original adjusted relative frequency table is merge CAL relative frequency table and the missing bins table. However, some bins in the CAL table do not exist in the CNF modeling region, but this does not impact the final prediction since the adjusted table is only used for assigning values. This update cleans up bins in the Adjusted Relative Frequency Table that are not present in the CNF modeling region.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where bins are missing during the prediction phase, the original adjusted relative frequency table is merge CAL relative frequency table and the missing bins table. However, some bins in the CAL table do not exist in the CNF modeling region, but this does not impact the final prediction since the adjusted table is only used for assigning values. This update cleans up bins in the Adjusted Relative Frequency Table that are not present in the CNF modeling region.