Skip to content

Conversation

@YaoTingYao
Copy link
Member

@YaoTingYao YaoTingYao commented Mar 18, 2024

Incorporated the remove_edge_cells function, contributed by @agcopenhaver in Issue #3, to improve the Thiessen Polygon Method by ensuring polygons maintain up to 99.9% of their maximum size. This modification facilitates the inclusion of more samples while accepting minor irregularities in some edge polygon shapes.

The decision to set the threshold at 99.9%—as opposed to 99%—addresses concerns over the impact of irregular edges. With a standard assessment grid cell area of 100,000 ha, a 1% translates to a significant area of 10 km^2. By adjusting the threshold to 99.9%, the maximum discrepancy is reduced to a more manageable 1 km^2 (0.1%), having a better balance between polygon integrity and sample inclusivity.

Using Para as an example :

The original Method
image

99% Threshold
Applying the 99% method yields pink polygons, allowing for more sample inclusion but results in some edge polygons have irregular square shape. A 1% criterion equates to an area of 10 km^2.
image
image
image

99.9% Threshold
Adopting the 99.9% method generates blue polygons, which similarly improve the number of samples while ensuring edge polygons exhibit less irregularity. In this case, a 0.1% criterion corresponds to an area of 1 km^2.
image
image
image

Incorporated the remove_edge_cells function, contributed by @agcopenhaver in Issue #3, to improve the Thiessen Polygon Method by ensuring polygons maintain up to 99.9% of their maximum size. This modification facilitates the inclusion of more samples while accepting minor irregularities in some edge polygon shapes.

The decision to set the threshold at 99.9%—as opposed to 99%—addresses concerns over the impact of irregular edges. With a standard assessment grid cell area of 100,000 ha, a 1% variance translates to a significant area of 10 km^2. By adjusting the threshold to 99.9%, the maximum discrepancy is reduced to a more manageable 1 km^2 (0.1%), having a better balance between polygon integrity and sample inclusivity.
@YaoTingYao YaoTingYao requested a review from agcopenhaver March 18, 2024 21:33
@YaoTingYao
Copy link
Member Author

Hi @agcopenhaver, thank you for your valuable contribution of the remove_edge_cells function. We'd like to suggest implementing a 99.9% threshold and have accordingly updated the relevant scripts. Could you please review the PR at your convenience? Cheers!

Copy link
Collaborator

@agcopenhaver agcopenhaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YaoTingYao YaoTingYao merged commit fe7d4d6 into main Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants