Fix build issue in oss-fuzz environment (1.0.2)#996
Merged
val-ms merged 2 commits intoCisco-Talos:dev/1.0.2from Aug 11, 2023
Merged
Fix build issue in oss-fuzz environment (1.0.2)#996val-ms merged 2 commits intoCisco-Talos:dev/1.0.2from
val-ms merged 2 commits intoCisco-Talos:dev/1.0.2from
Conversation
There is an error building clam with the rust nightly compiler: error[E0635]: unknown feature `proc_macro_span_shrink` --> /rust/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.56/src/lib.rs:92:30 | 92 | feature(proc_macro_span, proc_macro_span_shrink) | ^^^^^^^^^^^^^^^^^^^^^^ We need this to work because oss-fuzz is apparently using rust nightly in their image. Bumping the proc-macro2 crate version in Cargo.lock resolves the error.
Contributor
Author
|
Just confirmed this doesn't change the minimum supported rust version. It is still 1.61.0. |
Contributor
Author
|
fuzz-regression pipeline looking good again. |
val-ms
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an error building clam with the rust nightly compiler:
error[E0635]: unknown feature
proc_macro_span_shrink--> /rust/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.56/src/lib.rs:92:30
|
92 | feature(proc_macro_span, proc_macro_span_shrink)
| ^^^^^^^^^^^^^^^^^^^^^^
We need this to work because oss-fuzz is apparently using rust nightly in their image.
Bumping the proc-macro2 crate version in Cargo.lock resolves the error.