Merged
Conversation
ragusaa
force-pushed
the
CLAM-1931-AddUDFSupport
branch
from
8ae41e1 to
86867d8
Compare
val-ms
requested changes
Jun 24, 2023
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
I haven't tested yet, but from code review these are things I noticed.
ragusaa
commented
Jun 27, 2023
ragusaa
force-pushed
the
CLAM-1931-AddUDFSupport
branch
3 times, most recently
from
003632c to
071971f
Compare
val-ms
reviewed
Jul 18, 2023
ragusaa
force-pushed
the
CLAM-1931-AddUDFSupport
branch
2 times, most recently
from
b1b8370 to
4f265dd
Compare
ragusaa
force-pushed
the
CLAM-1931-AddUDFSupport
branch
from
5a28b15 to
523ab87
Compare
val-ms
approved these changes
Aug 3, 2023
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
Code review looks good. Manual testing looks good (notes in Jira under CLAM-2322). I'm happy. Waiting to see it pass through existing Jenkins build/tests. As noted, we don't have a benign sample to test with, so no automated test at this time.
Add support for specifically for Beginning Extended Area Descriptor (BEA01) type of UDF files.
val-ms
force-pushed
the
CLAM-1931-AddUDFSupport
branch
from
523ab87 to
2ca8903
Compare
Contributor
|
rebased because jenkins macos build failed because of openssl3 changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the Beginning Area Descriptor (BEA01) UDF files.