oss-fuzz - fixing overread/write when unpacking pe files#927
Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom Jun 12, 2023
Merged
oss-fuzz - fixing overread/write when unpacking pe files#927val-ms merged 1 commit intoCisco-Talos:mainfrom
val-ms merged 1 commit intoCisco-Talos:mainfrom
Conversation
val-ms
requested changes
May 25, 2023
Added a CLI_CONTAINS buffer wrap check to ensure we aren't reading and writing beyond the exe buffer
val-ms
approved these changes
Jun 12, 2023
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
Update looks good to me. And after finally resolving the jenkins py.xml issue, it passed nicely through the test pipelines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a CLI_CONTAINS buffer wrap check to ensure we aren't reading and writing beyond the exe buffer.
We determined that this bug is not a vulnerability.