Skip to content

Clam 2291 rc soversion news#871

Merged
val-ms merged 7 commits intoCisco-Talos:mainfrom
val-ms:CLAM-2291-rc-soversion-news
Mar 30, 2023
Merged

Clam 2291 rc soversion news#871
val-ms merged 7 commits intoCisco-Talos:mainfrom
val-ms:CLAM-2291-rc-soversion-news

Conversation

@val-ms
Copy link
Contributor

@val-ms val-ms commented Mar 25, 2023

Set release candidate version suffix and bump SOVERSION

Add news for recent 1.0.1, 0.105.2, and 0.103.8 patch versions

Update news for 1.1.0 release

Also small random fix:

  • CMake: Fix issue generating Rust bindings with -D MAINTAINER_MODE=ON

@ragusaa
Copy link
Contributor

ragusaa commented Mar 28, 2023

In win32/res/common.rc.in, should the line
#define RES_VER_S "ClamAV @PROJECT_VERSION_MAJOR@.@PROJECT_VERSION_MINOR@.@PROJECT_VERSION_PATCH@-devel"

be
#define RES_VER_S "ClamAV @PROJECT_VERSION_MAJOR@.@PROJECT_VERSION_MINOR@.@PROJECT_VERSION_PATCH@-rc"

??

@val-ms
Copy link
Contributor Author

val-ms commented Mar 28, 2023

@ragusaa TBH I wondered about that too. We haven't touched that line in a couple years, and when I looked at the "Properties" page for clamscan.exe, sigtool.exe, etc I found that they don't have the -devel suffix in there. So I think maybe it isn't even used?? I wonder if we can delete it entirely, or else fix it somehow so it does show up somewhere. Or maybe I'm looking in the wrong place.

@val-ms
Copy link
Contributor Author

val-ms commented Mar 28, 2023

I'll update this with changes to the NEWS.md after:

  1. we merge Clam 571 sigtool vba extraction improvements #852, Fix #820 - add new option --fail-if-cvd-older-than=days #867, and libclamav: Use OpenSSL' BN instead tomfastmath. #840
  2. our review of the release notes (in sharepoint) is complete

So maybe this evening or tomorrow I hope

@val-ms val-ms force-pushed the CLAM-2291-rc-soversion-news branch 2 times, most recently from fa7a900 to 0589437 Compare March 30, 2023 03:28
val-ms added 4 commits March 29, 2023 22:26
Change the version suffix from -devel-{TODAY} to -rc

Bump the SO version for libclamav and libfreshclam.
Increasing the current version to 12.0.0 and 3.0.0 respectively.
The reason is that we reintroduced using the version scripts:
- libclamav.map
- libfreshclam.map
- libclamunrar.map
- libclamunrar_iface.map

Note that libclamunrar and libclamunrar_iface use the SO version from
libclamav.

Note that libclammspack does not have a .map file and so is not getting
symbol versioning at this time nor are we bumping the SO version for
that library.
@val-ms val-ms force-pushed the CLAM-2291-rc-soversion-news branch from 0589437 to 33c80cb Compare March 30, 2023 05:27
val-ms added 2 commits March 29, 2023 22:48
Add Cargo.lock file so that we do not accidentally increase Rust
compiler version requirement via changes to library dependencies.
@val-ms val-ms force-pushed the CLAM-2291-rc-soversion-news branch from 33c80cb to 68fd6fe Compare March 30, 2023 05:48
@val-ms val-ms merged commit 4c5d548 into Cisco-Talos:main Mar 30, 2023
@val-ms val-ms deleted the CLAM-2291-rc-soversion-news branch March 30, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants