Allow passing in custom RUSTFLAGS#835
Conversation
|
Most of this makes sense to me, with the I am a little confused about one part of this change. Why do you want to remove the quotes around |
|
The quotes caused problems. It seems like cmake automatically quotes the arguments. |
val-ms
left a comment
There was a problem hiding this comment.
The quotes caused problems. It seems like cmake automatically quotes the arguments.
Very interesting. I didn't expect it to work this way, but I did some manual testing using options -D RUSTFLAGS="-g -v" and it seems good.
We may also consider adding some documentation to the top of this file explaining that you can set RUSTFLAGS cmake variable before using this module. But I don't feel strongly about it. I ran this through our automated tests a couple weeks ago and that looked good. May as well merge now.
Thanks for the PR @opoplawski
Also, according to https://cmake.org/cmake/help/latest/command/add_custom_command.html the
ARGSoption is ignored.