Skip to content

clamonacc: add logging to watchpoint hierarchy add#822

Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom
m-sola:onacc-log-new
Feb 9, 2023
Merged

clamonacc: add logging to watchpoint hierarchy add#822
val-ms merged 1 commit intoCisco-Talos:mainfrom
m-sola:onacc-log-new

Conversation

@m-sola
Copy link
Contributor

@m-sola m-sola commented Feb 2, 2023

Patch provides more insight into error conditions which may arise when adding a directory to the watch hierarchy. If a specific file caused the issue, the filename is provided to help users with any troubleshooting needed.

@m-sola m-sola requested a review from val-ms February 2, 2023 19:25
@val-ms
Copy link
Contributor

val-ms commented Feb 4, 2023

There are also some places where err (a cl_error_t return code) is printed directly. E.g.

            logg(LOGG_ERROR, "ClamInotif: could not parse include list (%d)\n", err);

It would probably help make if we switch to cl_strerror, like:

            logg(LOGG_ERROR, "ClamInotif: could not parse include list (%s)\n", cl_strerror(err));

Patch provides more insight into error conditions which may arise
when adding a directory to the watch hierarchy. If a specific file
caused the issue, the filename is provided to help users with any
troubleshooting needed.
@val-ms val-ms merged commit 73109eb into Cisco-Talos:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants