Add a version script for libclamunrar and libclamunrar_iface.#816
Closed
sebastianas wants to merge 1 commit intoCisco-Talos:mainfrom
Closed
Add a version script for libclamunrar and libclamunrar_iface.#816sebastianas wants to merge 1 commit intoCisco-Talos:mainfrom
sebastianas wants to merge 1 commit intoCisco-Talos:mainfrom
Conversation
Contributor
|
Thanks for submitting this Sebastian. This week has been hectic and I expect that week will be as well. I will look at this/test it as soon as I'm able. |
Closed
Without a version script all symbols will be exported which are public within the libclamunrar* libraries. This is true for the officially exported symbols as well as all the public symbols which are used within libraries and are not inteded for export. There is already a .map preset to limit the exported symbols of libclamunrar and libclamunrar_iface. Use it. Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
sebastianas
force-pushed
the
libclamunrar
branch
from
0035f0d to
2e4d3b3
Compare
Contributor
|
Since I closed your other version script PR ( #804 ) for the reasons mentioned there, I will close this as well. But I do see that #776 lacks the logic to use the libclamunrar.map. I am testing adding that new in personal branch. If that goes well, I'll just push it onto #776 along with a fix for the static library linking issue mentioned on that PR. Thank you Sebastian for working on this and encouraging it even though I'm not merging these specific PR's. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a version script all symbols will be exported which are public within the libclamunrar* libraries. This is true for the officially exported symbols as well as all the public symbols which are used within libraries and are not inteded for export.
There is already a .map preset to limit the exported symbols of libclamunrar and libclamunrar_iface. Use it.
Signed-off-by: Sebastian Andrzej Siewior [email protected]