Add an option to avoid setting RPATH on unix systems.#815
Add an option to avoid setting RPATH on unix systems.#815val-ms merged 3 commits intoCisco-Talos:mainfrom
Conversation
|
Thanks for submitting this Sebastian. Casually reading this, it makes sense to me. As noted on the other PR, this week has been hectic and I expect that week will be as well. I will give it more attention as soon as I can. |
|
Can you please also document the new option in https://github.com/Cisco-Talos/clamav/blob/main/INSTALL.md#custom-cmake-config-options Outside of this documentation request, I'm happy with the PR. |
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
Forgot to mark "request changes" for documentation change. Required to add a comment in order to do it ;-)
RPATH overrides the normal library search path, possibly interfering with local policy and causing problems for multi-lib, among other issues. Add an option to avoid setting it with letting it enabled by default. Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
|
done |
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
Some other very minor changes to make, please.
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
Because my requested changes here were miniscule, I did it myself and will just squash the extra fixup commits in the merge.
2 participants
RPATH overrides the normal library search path, possibly interfering with local policy and causing problems for multilib, among other issues.
Add an option to avoid setting it with letting it enabled by default.
Signed-off-by: Sebastian Andrzej Siewior [email protected]