Clam 2211 Add string length validation to public key strings#810
Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom Feb 2, 2023
Merged
Clam 2211 Add string length validation to public key strings#810val-ms merged 1 commit intoCisco-Talos:mainfrom
val-ms merged 1 commit intoCisco-Talos:mainfrom
Conversation
ragusaa
force-pushed
the
CLAM-2211-ValidateKeyLength
branch
from
4bd2e46 to
a86d03a
Compare
val-ms
approved these changes
Jan 31, 2023
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
Looks good! Will run through Jenkins, but local testing and review look good to me.
| * long causes an out of bounds read in the this call. | ||
| */ | ||
| if ((strlen(tokens[4]) / 2) >= (FP_MAX_SIZE / 8)) { | ||
| cli_errmsg("cli_loadcrt: line %u: Public key too long.\nNOTE: If this is actually a valid key length, recompile with a larger FP_MAX_SIZE (currently %d).\n", (unsigned int)line, FP_MAX_SIZE); |
val-ms
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.