Clam 2214 bounds checking regex suffix#807
Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom Feb 3, 2023
Merged
Conversation
ragusaa
force-pushed
the
CLAM-2214-BoundsCheckingRegexSuffix
branch
from
e2c9dc8 to
000816e
Compare
|
I wonders if this PR also fix regex in Yara too? |
Contributor
Author
I am sorry, I must have missed your comment. Do you happen to have a testcase I can try with this PR? |
|
It is back-references regex and I just found that back-references are not support in Yara rules. |
ragusaa
force-pushed
the
CLAM-2214-BoundsCheckingRegexSuffix
branch
from
50f63cf to
75ac275
Compare
val-ms
requested changes
Jan 30, 2023
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
Testing went well.
Outside of the above, looks good to me.
While searching for the end of the character class ']', there was no bounds checking to prevent reading past the end of the regular expression. This PR corrects that.
ragusaa
force-pushed
the
CLAM-2214-BoundsCheckingRegexSuffix
branch
from
75ac275 to
a5ee4c9
Compare
val-ms
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.